[mythtv] Ticket #8124: Themestring.h updates in r23643 appears to be wrong

[Kenni Lund]

2010/3/3 Robert McNamara <robert.mcnamara at gmail.com>:
> On Wed, Mar 3, 2010 at 10:08 AM, Kenni Lund <kenni at kelu.dk> wrote:
>> I still see (several hundreds?) strings which I suppose originate from
>> the plugins. I recognize a lot of them from when I translated the
>> plugins. Some random examples taken from
>> trunk/mythtv/themes/themestrings.h:
>>
<SNIP>
>
> Those are the unique strings of the themes in myththemes.  Those
> strings need translating too.
>

Thanks Robert, I figured that out shortly after posting, but isn't
this a very ineffective approach? (at least for us translators) A lot
of these strings are already translated in the themestrings of the
plugins, but since they are in another themestrings.h file, they need
to be translated once again. I did a quick test to see how many of the
translations in myththemes/metallurgy/music-ui.xml, which was already
translated in the themestrings.h of mythmusic:

Count the number of unique strings in music-ui.xml:
[kenni at T61 trunk]$ grep "<value>" myththemes/metallurgy/music-ui.xml |
sort -u | wc -l
33

Strip out the unique strings and save them in music-ui.txt:
[kenni at T61 trunk]$ grep "<value>"
myththemes/metallurgy/music-ui.xml|sed -e "s/^ *<value>//g" -e
"s/<\/value>//g"|sort -u > music-ui.txt

Check how many of these 33 strings that have already been translated
in the themestrings.h of mythmusic:
[kenni at T61 trunk]$ for i in $(cat music-ui.txt); do grep \"$i\"
mythplugins/mythmusic/i18n/themestrings.h ; done|wc -l
19

So 19 out of 33 strings (57%) were already translated in mythmusic,
but needs to get translated once again. My rough estimate tells me
that it's around 400 translations in total which has to be done twice.

Is the main issue that the themes expects the translations to be
within mythfrontend? Otherwise, wouldn't it be more sane to include
myththemes/*/music-ui.xml in the themestrings.h of mythmusic, etc.
That way similar translations would be consolidated. As far as I can
see it's the same *.xml filenames used in the different themes.

Best Regards
Kenni Lund