[mythtv] render2019 comments

[Klaas de Waal]

On Thu, 3 Oct 2019 at 21:57, Jonatan Lindblad <lindbladjonatan at gmail.com> wrote:
>
> Den 2019-10-03 kl. 10:58, skrev Mark Kendall:
> > On Wed, 2 Oct 2019 at 21:22, Jonatan Lindblad <lindbladjonatan at gmail.com> wrote:
> >>> Anyone familiar with the settings UI code have any ideas/suggestions?
> >>
> >> I'm afraid the documentation for theming the settings has not been written yet. You should however be able to do what you want with the states disabledinactive and disabledactive of the buttonitem statetype widget that is used in button lists. That's just standard MythUI but for settings there is also the widgettype statetype which can be used to display the type of a setting (checkbox, textedit, etc).
> >>
> >> Documentation of the button lists can be found here:
> >> https://www.mythtv.org/wiki/MythUI_Theme_Development#The_buttonlist_widget
> >>
> >> The current definition just changes the background for disabled settings:
> >> https://github.com/MythTV/mythtv/blob/master/mythtv/themes/default/standardsetting-ui.xml#L181
> >> https://github.com/MythTV/mythtv/blob/master/mythtv/themes/default/standardsetting-ui.xml#L188
> >
> > Jonatan,
> >
> > If I'm reading that correctly - then all I need to do is edit the
> > disabledinactive state?
>
> Yes, that is correct. You can check out Steppes for an example, https://github.com/MythTV-Themes/Steppes/blob/master/standardsetting-ui.xml#L169.
>
> > but presumably the standard settings is themed
> > individually and hence overridden by each theme... (showing my
> > ignorance here no doubt)
>
> It seems like the only themes customizing this are the different Steppes versions and Monochrome so if you update the default one most of the themes would actually benefit from it.
>
> Cheers
> Jonatan

The grey-out, as implemented now in 2019-render with commit "4fe3b:
Settings: Update standard theme to 'gray out' disabled settings" does
break mythtv-setup page "Capture Card / Card type". Here I apparently
use this attribute to skip the field 'Frontend ID' and that is now
grey. This field should not be grey because it is relevant to the
page; the field is skipped with editing becausee it shows content that
cannot  be edited.
Maybe we do need a separate function to set the grey/not-grey state of
a field? Or should I do something different for the "Frontend ID"
field?

Groetjes,
Klaas.