[mythtv] Re: [mythtv-commits] Ticket #857: Patch to mythrename.pl
to work correctly with slave backends
Tom Lichti
tom at redpepperracing.com
Fri Dec 23 16:44:15 EST 2005
Michael T. Dean wrote:
> Tom Lichti wrote:
>
>> Also, on your posted patch, how did you get the filenames the way you
>> did? Mine seems convoluted compared to yours. I'm referring to this
>> part:
>>
>> Index: contrib/mythrename.pl
>> ===================================================================
>> --- contrib/mythrename.pl (revision 8364)
>> +++ contrib/mythrename.pl (working copy)
>>
>>
>> I assume you are using a local SVN repo?
>
> Yep.
>
> Checked out with:
>
> $ svn co http://svn.mythtv.org/svn/trunk/mythtv
>
> Then edited contrib/mythrename.pl with:
>
> $ cd mythtv
> $ vi contrib/mythrename.pl
>
> (of course ;) and created the patch (from the mythtv directory) with:
>
> $ svn diff > ../mythrename-locally_accessible_files.patch
Woah. Lots of info there... :)
I have my own repo as well, I didn't realize you could do that. Anyway,
I was trying to debug my patch, since it doesn't remove any existing
links on subsequent runs. The problem is here:
foreach my $file (<$sub/*>) {
next unless (-l $file);
unlink $file or die "Couldn't remove old symlink
$file: $!\n";
}
If the path has a space in it, this code doesn't work, and I'm not sure
how to fix it (aside from not creating paths with spaces in them). There
also seems to be a problem with running on a slave, but first things
first...
Tom
More information about the mythtv-dev
mailing list