[mythtv] [patch] mythgame: small fix to make it compatible with mame version 0.87

mythtv at zwanebloem.nl mythtv at zwanebloem.nl
Fri Oct 15 09:37:31 UTC 2004


On Fri, Oct 15, 2004 at 01:20:25AM +0100, Charlie Brej wrote:
> mythtv at zwanebloem.nl wrote:
> >Hi,
> >
> >Options sound and mouse are no longer recognised by mame 0.87 so I added
> >a check for that.
> >
> >Regards,
> >
> >Tommy
> >
> 
> I was just about to submit a similar patch except this line:
> "if(general_prefs.xmame_minor<87){"
> should probably be
> "if(general_prefs.xmame_minor<87 && general_prefs.xmame_major <= 0){"
> 
> Assuming they will ever release a v1.0 ;) The nosound option can be still 
> specified by setting "-audiodevice" to a bogus device. Finally -fakesound 
> was also removed.
I missed that
> 
> I will steal your minor number comparison though ;) I didn't know you could 
> do that. How does it react if you have a version "0.87u1" ?
The way I understand minor/major are Qstrings and if I understand them
correctly they can be ints or strings or whatever overloading thing I
guess (I don't do much C++). Anyway I guess it would fail in such a
situation however I think a lot would fail if you would use an
intermittent release. 

Regards,

Tommy
> 
> Anyway my patch also included
> 
> 
> -- 
>         Charlie Brej
> APT Group, Dept. Computer Science, University of Manchester
> Web: http://www.cs.man.ac.uk/~brejc8/ Tel: +44 161 275 6844
> Mail: IT302, Manchester University, Manchester, M13 9PL, UK


> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev



More information about the mythtv-dev mailing list