[mythtv] [patch] Various SQL compability fixes and dbwrapper work-in-progress

David Härdeman david at 2gen.com
Sun Nov 21 15:24:34 UTC 2004


On Sat, Nov 20, 2004 at 12:46:10AM -0500, Isaac Richards wrote:
>Looks like a very good start.  
>
>For the fix patch, would you mind moving the Open function into the mythdbcon 
>file?  I think it'd belong better there..  Instead of changing all those "s 
>to 's in the queries, I'd also really prefer if things were switched to use 
>the prepare/bindValue methods.   I think it's cleaner, and it takes care of 
>proper quoting/etc..
>
>For the abstraction layer, is there any reason why you didn't split it up into 
>two classes, one for mysql, one for pg?  You could get rid of all the
>
> if (type == DBTYPE_PGSQL) 
>
>stuff that way.  Make it a bit easier to read, I think. =)
>

Thanks for the feedback and comments...I'll redo the patch along your 
suggestions...first patches should only be prepare/bindValue changes and 
I'll save the more controversial stuff for later.

Regards,
David


More information about the mythtv-dev mailing list