[mythtv] [PATCH] MediaMonitor data and MythVideo support
Matt Porter
mporter at kernel.crashing.org
Tue Jun 29 12:03:29 EDT 2004
On Tue, Jun 29, 2004 at 09:10:01AM -0400, J. Donavan Stanley wrote:
> Xavier Hervy wrote:
> > What i don't understand in your patch is the include in mythcontext.h
> > +#include <mythtv/mythmediamonitor.h>
> > +#include <mythtv/mythmedia.h>
> > instead of
> > +#include <mythmediamonitor.h>
> > +#include <mythmedia.h>
> > If you make a fresh install
> > mythtv/mythmediamonitor.h and mythtv/mythmedia.h don't exist, no ?
> > if it works, can you explain why ? (and we don't need to change all
> > .pro file for each plugin :))
>
> Your include path for every module should include the directories where
> your mythtv files are..
I think this point is moot now, since we should change MediaMonitor
to a singleton class. This was only an issue when the references
to MediaMonitor were added to the mythcontext.
> > I use a usb drive and i would like that mediamonitor support it. I
> > agree with you, we need MEDIATYPE_VIDEODATA, MEDIATYPE_AUDIODATA and
> > MEDIATYPE_PICTUREDATA. But keep in mind that we need need to know if
> > it's a CD/DVD Data or an usb drive or something else.
>
>
> USB types of devices are pretty easy to add. Since they, and firewire
> drives, use SCSI emulation you just need to track SCSI emulation found
> in fstab.
I actually had planned on adding a mythhotplug method that will
listen for hotplug events on a socket from an /sbin/hotplug script
that sends the events on said socket. Of course, we might just
require the user's /sbin/hotplug to mount the device and poll
the mounts rather than being directly hotplug event driven.
Oh, and my thoughts on DATA type detection were to use extensions
from the videotype table in a QDir search to determine a
MEDIATYPE_VIDEODATA media. We can use a static set of extensions
(those known to be handled by mythmusic/mythgallery to determine
a MEDIATYPE_AUDIODATA and MEDIATYPE_IMAGEDATA media). Adding this
finer-grained DATA type detection would require it moving out of
mythcdrom.cpp since it would be used by a mythhotplug.cpp (I
might have any of those data types on a hotplug device).
The big end-user problem is when somebody mixes DATA types on
media. Something will have to be worked out to determine which
data type has priority (for launching a handler).
-Matt
More information about the mythtv-dev
mailing list