[mythtv] [PATCH] MediaMonitor data and MythVideo support

[J. Donavan Stanley]

Xavier Hervy wrote:

> Hi Matt,
> I take a look on the both patch but i try them.
> First, Iimade a lot of change in mythvideo, that include cd 
> collections in. then i think your clean code for mythvideo isn't 
> appropriate now. sorry ;-)
> for the second patch, i just wake up, then my brain don't run 
> normally. I don't see the difference betwen you patch and mine. i made 
> a diff -u between the both patch but the result is rubbish. ;-)

This came out of a conversation on IRC about pending media monitor 
patches.  It's much better to have smaller more focused patches.  Which 
is one of the reasons I asked you about any pending patches *you* might 
have offlist.



> Can you tell me what exactly you change ?
> Because i add in my mediamonitor the capability to ask the volumename 
> and keyid for each cd in iso9660 and udf.
>
> What i don't understand in your patch is the include in mythcontext.h
> +#include <mythtv/mythmediamonitor.h>
> +#include <mythtv/mythmedia.h>
> instead of
> +#include <mythmediamonitor.h>
> +#include <mythmedia.h>
> If you make a fresh install
> mythtv/mythmediamonitor.h and mythtv/mythmedia.h don't exist, no ?
> if it works, can you explain why ? (and we don't need to change all 
> .pro file for each plugin :))

Your include path for every module should include the directories where 
your mythtv files are..


> I use a usb drive and i would like that mediamonitor support it. I 
> agree with you, we need MEDIATYPE_VIDEODATA, MEDIATYPE_AUDIODATA and 
> MEDIATYPE_PICTUREDATA. But keep in mind that we need need to know if 
> it's a CD/DVD Data or an usb drive or something else.


USB types of devices are pretty easy to add.  Since they, and firewire 
drives, use SCSI emulation you just need to track SCSI emulation found 
in fstab.