[mythtv] [PATCH] MediaMonitor data and MythVideo support

[Xavier Hervy]

Hi Matt,
I take a look on the both patch but i try them.
First, Iimade a lot of change in mythvideo, that include cd collections 
in. then i think your clean code for mythvideo isn't appropriate now. 
sorry ;-)
for the second patch, i just wake up, then my brain don't run normally. 
I don't see the difference betwen you patch and mine. i made a diff -u 
between the both patch but the result is rubbish. ;-)
Can you tell me what exactly you change ?
Because i add in my mediamonitor the capability to ask the volumename 
and keyid for each cd in iso9660 and udf.

What i don't understand in your patch is the include in mythcontext.h
+#include <mythtv/mythmediamonitor.h>
+#include <mythtv/mythmedia.h>
instead of
+#include <mythmediamonitor.h>
+#include <mythmedia.h>
If you make a fresh install
mythtv/mythmediamonitor.h and mythtv/mythmedia.h don't exist, no ?
if it works, can you explain why ? (and we don't need to change all .pro 
file for each plugin :))

Matt Porter wrote:
> Hi,
> 
> I went through Xavier's patches and removed all the things that
> weren't being utilized and extra commented code. I'm left with
> two patches that are working well on my systems.
> 
> The first patch detects any mounted "cdrom" media as MEDIATYPE_DATA
> if it doesn't match with the dvd/vcd/svcd path probing.  In the
> future, I plan to make this better by parsing videotypes to detect
> a MEDIATYPE_VIDEODATA media. Likewise, MEDIATYPE_AUDIODATA can be
> detected for mythmusic handling. In addition, it adds a hook to
> MythContext so the plugin can get information on which media
> monitor devices have matching MEDIATYPE info. Also, I removed
> O_EXCL so a mounted device can be opened for ioctls to work
> and made sure a mounted device was unmounted when MEDIASTATUS_OPEN
> occurs.
I use a usb drive and i would like that mediamonitor support it. I agree 
with you, we need MEDIATYPE_VIDEODATA, MEDIATYPE_AUDIODATA and 
MEDIATYPE_PICTUREDATA. But keep in mind that we need need to know if 
it's a CD/DVD Data or an usb drive or something else.
> 
> The second patch just cleans up the basic videotree media handling
> code, and is functionally equivalent to Xavier's original.
> 
> I've been giving this a workout on my systems with vcd/svcd, cdda, and
> iso9660 (.avi,.mpg) media.  It's working real well. This should provide
> a good base for more intricate mythvideo media support that has been
> mentioned a few times, though it's useful as is.
> 
> Comments?
> 
> -Matt
> 
Xavier