[mythtv] [PATCH] MediaMonitor data and MythVideo support

[J. Donavan Stanley]

Matt Porter wrote:

>On Tue, Jun 29, 2004 at 09:10:01AM -0400, J. Donavan Stanley wrote:
>  
>
>>Xavier Hervy wrote:
>>    
>>
>>>What i don't understand in your patch is the include in mythcontext.h
>>>+#include <mythtv/mythmediamonitor.h>
>>>+#include <mythtv/mythmedia.h>
>>>instead of
>>>+#include <mythmediamonitor.h>
>>>+#include <mythmedia.h>
>>>If you make a fresh install
>>>mythtv/mythmediamonitor.h and mythtv/mythmedia.h don't exist, no ?
>>>if it works, can you explain why ? (and we don't need to change all 
>>>.pro file for each plugin :))
>>>      
>>>
>>Your include path for every module should include the directories where 
>>your mythtv files are..
>>    
>>
> 
>I think this point is moot now, since we should change MediaMonitor
>to a singleton class. This was only an issue when the references
>to MediaMonitor were added to the mythcontext.
>  
>

This is now in..


>Oh, and my thoughts on DATA type detection were to use extensions
>from the videotype table in a QDir search to determine a
>MEDIATYPE_VIDEODATA media. We can use a static set of extensions
>(those known to be handled by mythmusic/mythgallery to determine
>a MEDIATYPE_AUDIODATA and MEDIATYPE_IMAGEDATA media). Adding this
>finer-grained DATA type detection would require it moving out of
>mythcdrom.cpp since it would be used by a mythhotplug.cpp (I
>might have any of those data types on a hotplug device).
>  
>
The way I had originally envisioned this working was that multiple 
handlers could register for the same type.  Then when we handler the 
event we can prompt the user if there's more than one handler.  That's 
the reason why I kept the text information in the structs when I copied 
over the jump point logic to use for media handlers. 

Trying to add detectors for all the different media types is a losing 
battle...  It's one thing for fixed types such as DVDs, but once you 
start dealing with a bunch of files on a disk it could be anything, or 
even a mix of things.  The user knows what they stuck in the drive, it's 
better to just ask them:

    What do you want to do with this disk?
          Open in MythVideo
          Open in MythMusic
          Open in SomeOtherRegisteredHandlerFor_MEDIATYPE_DATA
          Do nothing.


As it turns out, the only disks I stick in my machines are either DVDs 
or Music CDs so the current handlers work well enough for me.  I tried 
to plan ahead to make it fairly easy to extend this, it's just not been 
on my radar.