[mythtv] conflict resolution

[Bruce Markey]

David Engel wrote:
> On Thu, Nov 06, 2003 at 11:16:07PM -0800, Bruce Markey wrote:
> 
>>Perfect. Now, if you turn on recorddups for Nova, do you see
>>that all three Wright Brothers showings are marked to record
>>or does it still just mark one of them for recording?
> 
> 
> Both with and without override, I only get one showing marked to
> record.

Yes! That's it! You've found it! That's the bug! 8-)

It is not marking every showing to be recorded even if it
is a duplicate. By definition, that is the bug. It should mark
all three to be recorded if "Allow recording even if duplicate
episode" is true.

The recorddups feature has worked for me and recorded all
showings ever since it went in a few months ago (okay, there
has been at least one bug ;-). I don't understand why you
would only see one showing marked to record if using current
CVS and recorddups on but I know this feature does work and it
should record all three.

I use this feature on "PGA Golf" to record Tiger Woods. Sometimes
different rounds of a tournament have the same subtitle and desc.
so I have recorddups on and it records all rounds. When I ran
the override patch on my test machine, I noticed that some
"PGA Golf" were gray and marked as nrOtherShowing even though
recorddups was turned on. Turning recorddups on and off made no
difference(!). I reinstalled clean CVS and saw that all "PGA Golf"
were correctly marked for record including the showings that were
grayed-out with the override patch. I then chose "Nova" as a
common test case and tried to send the steps to demonstrate
this bug. 

My apologies if I failed to convey that all showing should be
marked to record when this flag is set and that the new override
version is not marking all showings for record.

Anyway, I've narrowed down the problem in the override version
a little more...

There are two situations where recorddups needs to be considered.
First, when an episode is already in the oldrecorded table. This
appears to work correctly or at least finds that another showing
needs to be recorded. Second, when there are multiple upcoming
episodes. In this case it still marks all but one of the showing
as nrOtherShowing rather than marking them all for record.

Here is some test output. I've added line numbers and subtitles
to clarify things a bit.

"The Elegant Universe: Welcome to the 11th Dimension" is already
in the oldrecorded table and has two upcoming showings. "Wright
Brothers' Flying Machine" has not been recorded and has three
upcoming showings. There is just one upcoming showings of
"Cancer Warrior" and it has not been recorded previously.

With recorddups turned off for 'Nova':
--- print list start ---
Title           Chan  ChID  StartTime       S I C -- C R O N Rank Total
1 Nova (Elegant)  10  1010  Nov 09 02:00am  1 1 1 -- 0 0 0 2    0    0
2 Nova (Elegant)  10  1010  Nov 09 10:00am  1 1 1 -- 0 0 0 2    0    0
3 Nova (Wright)   10  1010  Nov 11 08:00pm  1 1 1 -- 0 1 0 0    0    0
4 Nova (Wright)   10  1010  Nov 12 01:00am  1 1 1 -- 0 0 0 4    0    0
5 Nova (Wright)   10  1010  Nov 12 03:00am  1 1 1 -- 0 0 0 4    0    0
6 Nova (Cancer)   10  1010  Nov 13 09:00pm  1 1 1 -- 0 1 0 0    0    0
---  print list end  ---

Lines 1 and 2 are correctly marked as nrPreviousRecording.
Lines 4 and 5 are marked correctly as nrOtherShowing because
line 3 will be recorded.

With recorddups turned on for 'Nova':
--- print list start ---
Title           Chan  ChID  StartTime       S I C -- C R O N Rank Total
1 Nova (Elegant)  10  1010  Nov 09 02:00am  1 1 1 -- 0 1 0 0    0    0
2 Nova (Elegant)  10  1010  Nov 09 10:00am  1 1 1 -- 0 0 0 4    0    0
3 Nova (Wright)   10  1010  Nov 11 08:00pm  1 1 1 -- 0 1 0 0    0    0
4 Nova (Wright)   10  1010  Nov 12 01:00am  1 1 1 -- 0 0 0 4    0    0
5 Nova (Wright)   10  1010  Nov 12 03:00am  1 1 1 -- 0 0 0 4    0    0
6 Nova (Cancer)   10  1010  Nov 13 09:00pm  1 1 1 -- 0 1 0 0    0    0
---  print list end  ---

Line 1 is correctly marked to be recorded even though it is
a duplicate of an oldrecorded entry. However, line 2 is now 
nrOtherShowing. It should instead be marked to record as well
as lines 4 and 5.

Simulated output of what should be expected for recorddups on:
--- print list start ---
Title           Chan  ChID  StartTime       S I C -- C R O N Rank Total
1 Nova (Elegant)  10  1010  Nov 09 02:00am  1 1 1 -- 0 1 0 0    0    0
2 Nova (Elegant)  10  1010  Nov 09 10:00am  1 1 1 -- 0 1 0 0    0    0
3 Nova (Wright)   10  1010  Nov 11 08:00pm  1 1 1 -- 0 1 0 0    0    0
4 Nova (Wright)   10  1010  Nov 12 01:00am  1 1 1 -- 0 1 0 0    0    0
5 Nova (Wright)   10  1010  Nov 12 03:00am  1 1 1 -- 0 1 0 0    0    0
6 Nova (Cancer)   10  1010  Nov 13 09:00pm  1 1 1 -- 0 1 0 0    0    0
---  print list end  ---

If "Allow recording even if duplicate episode" is true then all
six should be recorded with no consideration of matching subtitle
and description.

And to to think that just yesterday I thought I could describe
this by simply saying "recorddups isn't honored" and "R=0, N=4".
Silly me ;-).

--  bjm