[mythtv-users] MythUtil interest?

[Michael T. Dean]

On 08/31/2016 09:05 AM, Philip Brady wrote:
>> At some point I will try to write up a couple of issues/limitations I
>> encountered with using the services API and send them to the
>> devs for consideration (and try to create patches if I can figure
>> how to address the issue(s)).
> Gary,
>
> if you are taking requests for fixes to API then these are hitting my channel editor:
>
> 1.  UpdateDBChannel  ignores attempt to set null values for XMLTVID
> https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmythtv/channelutil.cpp
> lines 1595 and 1628 thought to be the culprits.

What do you mean by "ignores attempt to set null values"?  I think you 
mean to say it ignores attempts to clear the value stored in the field.  
The xmltvid field is:

`xmltvid` varchar(255) NOT NULL DEFAULT ''

so it definitely should /not/ allow it to be set to null.  Are you 
saying you're unable to clear its value--to set it to the empty string?  
If so, that will need to be fixed (and, likely, will require changes for 
a lot of other fields throughout the API).

> 2.  UpdateDBChannel  does not allow CommFree to be changed

CommFree doesn't exist.  It's derived data--derived from the 
commmethod--"displayed" only for convenience of interpretation/ease of 
visibility.  When you set commmethod, you set commfree.

https://github.com/MythTV/mythtv/blob/master/mythtv/libs/libmyth/programtypes.h#L93

Therefore, you should not be allowed to set commfree--as allowing so 
would result in ambiguity when both commmethod and commfree are specified.

Mike