[mythtv] [mythtv-commits] [MythTV/mythtv] 539502: Remove 'Use fixed window size' setting

[Craig Treleaven]

> On Oct 18, 2019, at 4:58 AM, Mark Kendall <noreply at github.com> wrote:
> 
>  Branch: refs/heads/devel/2019-render
>  Home:   https://github.com/MythTV/mythtv
>  Commit: 539502f914f4dde4fe495675340997a28f5177df
>      https://github.com/MythTV/mythtv/commit/539502f914f4dde4fe495675340997a28f5177df
>  Author: Mark Kendall <mark.kendall at gmail.com>
>  Date:   2019-10-16 (Wed, 16 Oct 2019)
> 
>  Changed paths:
>    M mythtv/libs/libmythtv/tv_play.cpp
>    M mythtv/libs/libmythtv/tv_play.h
>    M mythtv/libs/libmythui/mythmainwindow.cpp
>    M mythtv/programs/mythfrontend/globalsettings.cpp
> 
>  Log Message:
>  -----------
>  Remove 'Use fixed window size' setting
> 
> - this wasn't doing anything until recent commits
> - it is not useful as we never resize the GUI (which would require
> significant work)
> - resizing is not the cause of other issues under investigation
> - fixes a problem with the main window not resizing back to the GUI size
> after playback using fullscreen
> - don't move the window after changing back to GUI - it was moving the
> window after each playback exit.
> 
> 
>  Commit: 40c450f03eda1366aed5efabbb79c8a3d8d8028a
>      https://github.com/MythTV/mythtv/commit/40c450f03eda1366aed5efabbb79c8a3d8d8028a
>  Author: Mark Kendall <mark.kendall at gmail.com>
>  Date:   2019-10-17 (Thu, 17 Oct 2019)
> 
>  Changed paths:
>    M mythtv/libs/libmythtv/tv_play.cpp
>    M mythtv/libs/libmythui/mythmainwindow.cpp
>    M mythtv/libs/libmythui/mythmainwindow.h
> 
>  Log Message:
>  -----------
>  MythMainWindow: Add some consistency to window resizing/moving
> 
> - add MoveResize method that always resizes the main window and the
> painter window (if created).
> - replaces a lot of sundry/inconsistent resizing with one call for
> better tracking of windowing issues.
> 
> 
>  Commit: dee450804c5a3c1b65a705afa5975da8c92ac8de
>      https://github.com/MythTV/mythtv/commit/dee450804c5a3c1b65a705afa5975da8c92ac8de
>  Author: Mark Kendall <mark.kendall at gmail.com>
>  Date:   2019-10-18 (Fri, 18 Oct 2019)
> 
>  Changed paths:
>    M mythtv/libs/libmythtv/mythplayer.cpp
>    M mythtv/libs/libmythtv/openglvideo.cpp
>    M mythtv/libs/libmythtv/openglvideo.h
>    M mythtv/libs/libmythtv/videoout_d3d.h
>    M mythtv/libs/libmythtv/videoout_null.h
>    M mythtv/libs/libmythtv/videoout_opengl.cpp
>    M mythtv/libs/libmythtv/videoout_opengl.h
>    M mythtv/libs/libmythtv/videooutbase.cpp
>    M mythtv/libs/libmythtv/videooutbase.h
>    M mythtv/libs/libmythtv/videoouttypes.h
>    M mythtv/libs/libmythtv/videooutwindow.cpp
>    M mythtv/libs/libmythtv/videooutwindow.h
> 
>  Log Message:
>  -----------
>  Fix sundry display issues when using fullscreen and/or resolution
> switching
> 
> - update VideoOutWindow to only process changes when a parameter has
> actually changed. This avoids unnecessary signals to the video classes
> and attempts to stop spamming the logs with updates.
> - focus on the window size in VideoOutWindow as we are always bound by
> the window size - not the display size - and other areas of the code
> need to ensure the window is resized and VideoOutWindow updated as
> necessary
> - 'display visible rect' is not pertinent to OpenGLVideo - the window
> rect is king for the OpenGL view port (we previously used display
> visible rect as a bad proxy as it was never updated).
> - reimplement WindowResized in VideoOutputOpenGL to ensure we pick up
> window resizing events.
> - sundry removal of unused methods/members
> - NB there are still various issues. OSD font sizing when the window has
> been resized is erratic for some reason (both when switching to
> fullscreen and using display resolution switching). When using display
> resolution switching, switching to the guide grid etc is not working
> quite right and needs more work.
> 
> 
> Compare: https://github.com/MythTV/mythtv/compare/23421d288b61...dee450804c5a

Hi Mark:

Could any of these commits have helped with the macOS screen display problems I experienced with MythTV 29?  Only about 1/4 of the screen at the top-left was being used unless I overrode the GUI dimensions.  See:

https://forum.mythtv.org/viewtopic.php?f=26&t=2216&p=14335#p14335

Craig