[mythtv] Ticket #12809: Use lastPlayPos rather than bookmark
Peter Bennett
pb.mythtv at gmail.com
Thu Dec 28 22:09:23 UTC 2017
On 12/27/2017 07:35 PM, Peter Bennett wrote:
>> I'm not aware of Piotr's mods.
>>
>> I have seen occasional failures in the UI reported position but have
>> never bothered to debug it. Getting it committed would expedite that!
>>
>> Regards
>>
>>
> Piotr
>
> I compared your first patch against Roger's and they were 99% the
> same. You did make a few changes, I think you added something to a
> menu in one place, plus some others. I would like you to separate out
> your changes and give a small explanation of the purpose, so that when
> we are ready we can commit Roger's code and then commit your changes
> after that. This way we can easily identify where everything came
> from, and the reasons for each change.
>
Piotr
Roger's changes have many many conflicts when trying to apply them, due
to many changes in the system since they were created. I spent a couple
of hours fixing them, but still there were compile errors due to the new
setup. They were still using the old setup classes. I am going to take
your version. No need to try separating your changes out, it looks like
they are necessary to get past the conflicts.
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20171228/0dad6526/attachment.html>
More information about the mythtv-dev
mailing list