[mythtv] Ticket #12809: Use lastPlayPos rather than bookmark

[Peter Bennett]

On 12/27/2017 06:05 PM, Roger Siddons wrote:
> On Wed, 27 Dec 2017 17:58:52 -0000
> "MythTV" <noreply at mythtv.org> wrote:
>
>> #12809: Use lastPlayPos rather than bookmark
>> -------------------------------------+-----------------------------
>>   Reporter:  rsiddons                 |          Owner:  rsiddons
>>       Type:  Patch - Feature          |         Status:  assigned
>>   Priority:  minor                    |      Milestone:  29.1
>> Component:  MythTV - Video Playback  |        Version:  Master Head
>>   Severity:  low                      |     Resolution:
>>   Keywords:                           |  Ticket locked:  0
>> -------------------------------------+-----------------------------
>>
>> Comment (by pbennett):
>>
>>   Roger
>>
>>   Can I help with getting your patches in? I suggest applying them to
>>   master, rather than 29.1 as you had suggested.
>>
>>   Regarding a service that can support the last played position. There
>> are at the moment services !GetSavedBookmark and !SetSavedBookmark. I
>> could add !GetLastPlayPos and !SetLastPlayPos for Kodi and others to
>> use. It is time for me to learn about the MythTV services, so if you
>> agree I can get going on that so that we can commit this stuff.
>>
>>   Also there are some small changes in Piotr's version of the patches,
>> which probably should also be included.
>>
>>   Peter
>>
> Hi Peter,
>
> Are you running out of things to fix?
>
> Yes, it'll be good to get that cleared up.
>
> I found an old patch (attached) that seems to apply cleanly.
> It's never been tested though. I was hoping to avoid testing it
> manually but my plans have been waylaid, as usual.
> So you're most welcome to play with it.
>
> It includes PROGSTART and others.
> Seems to me a client would usually want several marks so it makes more
> sense to group them together rather than cluttering the API and
> requiring repeated calls. New marks can then be added easily.
>
> I'm not aware of Piotr's mods.
>
> I have seen occasional failures in the UI reported position but have
> never bothered to debug it. Getting it committed would expedite that!
>
> Regards
>
>
Piotr

I compared your first patch against Roger's and they were 99% the same. 
You did make a few changes, I think you added something to a menu in one 
place, plus some others. I would like you to separate out your changes 
and give a small explanation of the purpose, so that when we are ready 
we can commit Roger's code and then commit your changes after that. This 
way we can easily identify where everything came from, and the reasons 
for each change.

Peter