[mythtv] [mythtv-commits] Ticket #12959: mythfrontend 0.28 livetv does not display input connection display name on 'C' or 'Y' anymore

John P Poet jppoet at gmail.com
Mon Dec 19 18:57:33 UTC 2016

On Sun, Dec 18, 2016 at 10:04 PM MythTV <noreply at mythtv.org> wrote:

> #12959: mythfrontend 0.28 livetv does not display input connection display
> name on
> 'C' or 'Y' anymore
> -------------------------------------+-------------------------------------
>      Reporter:  Robert Watson        |      Owner:
>   <robertabcdefgwatson@…>            |
>          Type:  Bug Report -         |     Status:  new
>   General                            |
>      Priority:  minor                |  Milestone:  unknown
>     Component:  MythTV - Video/OSD   |    Version:  0.28.0
>   Rendering                          |   Keywords:  OSD livetv switchcard
>      Severity:  low                  |  switchinput
> Ticket locked:  0                    |
> -------------------------------------+-------------------------------------
>  I recently updated to MythTV0.28 and noticed this problem. As it is a
>  small problem and well defined, I thought I would have a look at it
>  myself. I am proposing a fix but as this is my first time looking into
>  MythTV I would like someone else to have a look at the proposed fix. Also,
>  to be completely honest, I don't know 100% why the fix works.
>  I am a complete newbie when it comes to open source and creating/fixing
>  bugs so forgive my errors but do let me know where I could do better.
>  The fix is in tv_play.cpp, method TV::!SwitchInputs() and the entire fix
>  is to swap these two lines:
>      UpdateOSDInput(ctx);\\
>      UnpauseLiveTV(ctx);
>  The Master branch appears to have the same issue when I look at the code
>  so I suspect the bug has not been dealt with by anyone. Please note I have
>  not compiled or test the master branch, only my code change in 0.28.
> --
> Ticket URL: <https://code.mythtv.org/trac/ticket/12959>

Thank you, Robert, for tracking this down.

How familiar are you with git?  I assumed you did a `git clone` to grab the
source.  After making your change you can do a `git diff` to see the
changes.  Further you can do a `git diff > ticket12959.patch` (or something
like that) to save the diff to a file, which you can then attach to the
ticket.  If you attach the patch to the ticket, I will take a look at it.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20161219/05959b85/attachment.html>

More information about the mythtv-dev mailing list