[mythtv] eitfixup for Greek
yiannividalis at hotmail.com
Mon Apr 20 07:01:48 UTC 2015
> Date: Sun, 19 Apr 2015 22:06:35 +0100
> From: stuarta at squashedfrog.net
> To: mythtv-dev at mythtv.org
> Subject: Re: [mythtv] eitfixup for Greek
> On 15/04/15 22:27, Roger Siddons wrote:
>> That comment is pre-2006 and I believe it's no longer valid/relevant.
>> The table is populated by libmythtv/dbcheck.cpp but it hasn't been used
>> by any code since 2007
> Yep, those DB tables haven't been used for a long time.
> The regexp handling became to much of a cpu overhead. Now they are built
> in and perform much better.
Pitty, it would have been great to have a page in mythtv-setup where people could enter info like:
- db fields it adds
- netword ids/ service ids, etc it affects
- event fields it should be applied on (title, description)
- if the parsed info should be removed from the fields or not
- more ideas?
> Keep reading eitfixup.cpp & .h and you should see how it's all defined
> and how it all hangs together
> Stuart Auchterlonie
Thanks Roger, Stuart for your responses.
It's almost unbelievable, but I've managed to read through the code and implement some fixups for
Greek eit on my faithful old laptop. I can say it works(!) and the db is populated with presenters, actors,
directors, episode and season numbers, and all sort of data that was just part of the description / title fields.
I've not yet patched my main master backend, the code is still in the laptop, trying to sort out some glitches mainly
caused by lack of punctuation in the descriptions!
I also want to add some more code (categories, parental level, etc) before I create a ticket with the patches I'll make.
I've some questions:
I've seen in the code in eithelper.cpp that at least one provider (lines 510 onward) is using the content.Nibble1(0)
field for category management. In my case, some stations use nibble2, with nibble1 always being 0:
DVB-DescriptorTag: 84 (0x54) [= content_descriptor]
descriptor_length: 2 (0x02)
Content_nibble_level_1: 0 (0x00)
Content_nibble_level_2: 1 (0x01)
User_nibble_1: 0 (0x00)
User_nibble_2: 0 (0x00)
Is it ok if I implement categories using nibble2? Are the greek providers wrong in their implementation? I guess it's more
of a "policy" question on my part.
If (when) I submit the patch, what other info should I attatch for the devs to review and verify the code? I mean apart from
punctuation and code structure. How could they (you) verify it works? After all, it'll all be Greek to you ;)
Also, I can only vouch that the code works for the transponders I receive (this mainly affects the local channels that are not
present elswhere in greece). Is this ok? I guess I'll have to wait for some other Greeks to check and provide me with some
dvbsnoop eit data to see.
Also (again), since I'm not very familiar with git, I create the patch whith git diff on the affected files, i.e, all the changes are
in one big patch. Could someone post some quick info/tips if I'm supposed to use git / github for patches / commits?
Sorry for the long post, and my apologies if some of my questions seem ... childish
I must say it's been a very educational experience, and that it... feels good to contribute. Thanks again for this great program.
More information about the mythtv-dev