[mythtv] Pull requests sufficient?
Michael T. Dean
mtdean at thirdcontact.com
Sat May 5 14:22:34 UTC 2012
On 05/05/2012 09:27 AM, Stuart Morgan wrote:
> On Saturday 05 May 2012 13:13:54 Paul Gardiner wrote:
>> I see. Ok. Thanks for the info. I guess github gets updated every now
>> and then, and so isn't wildly out of date for casual developers.
> One of our post-commit hooks syncs our repo with the copy on github.
(meaning the public repo on github is just as up to date as the repo on
our server).
Also wanted to mention that the "historical" benefit of a ticket on Trac
(that references your pull request): it's archived in Trac and in our
mailing list archive. Any github-only communication is "lost" (or at
least buried in a separate location that makes finding information
harder than searching one location). This makes it very challenging to
later figure out what happened.
We're considering making some changes that would make it easier to
create a ticket in conjunction with the pull requests, but haven't yet
figured out exactly how we want to handle it. We're hoping to come up
with an approach that makes it easy for users/submitters but that
maintains the historical benefit. Unfortunately, we haven't yet come up
with a good mix of automation that doesn't result in one or more party
having to do extra work. (I.e. if we automatically create a ticket, it
will then have to be triaged--probably including writing a proper
subject/description and linked to/moved to any existing ticket that
covers the issue--or if we require specific information/format in the
pull request (to allow creating/adding to the proper ticket), a user who
submits a pull request would have to look that up before submitting (not
to mention just knowing about the procedure). And, if we were to just
send an e-mail "form letter" in response to the github pull request
email for the user to fill out/return, it's actually probably just as
easy to send them a link to the Trac New Ticket page. We may end up
just doing that last approach until we can figure something else out, if
for no other reason than to let users know that we do prefer a Trac
ticket in addition to/referencing the pull request.)
Mike
More information about the mythtv-dev
mailing list