[mythtv] [mythtv-commits] mythtv/master commit: 85a5266e1 by Michael T. Dean (sphery)

[Jim Stichnoth]

On Wed, Apr 20, 2011 at 6:33 PM, MythTV <noreply at mythtv.org> wrote:
>      Author:  Michael T. Dean <mdean at mythtv.org>
>  Change Date:  2011-04-20T18:32:06-07:00
>   Push Date:  2011/04/20 18:33:05 -0700
>  Repository:  mythtv
>      Branch:  master
> New Revision:  85a5266e1218adac5e61839a2eab2afe2ea6a419
>   Changeset:  https://github.com/MythTV/mythtv/commit/85a5266e1
>
> Log:
>
> Fix EIA-608 caption color.
>
> Fix the color for EIA-608 captions, by fixing a min/max transposition.
> Since 99.99993% of all 608 captions are white, this change is unlikely
> to be noticed by anyone (and also explains why no one noticed the
> transposition).
>
> Modified:
>
>   mythtv/libs/libmythtv/subtitlescreen.cpp

Mike,

I would put your statistic closer to 99.9%, since the caption at the
very end of the program (telling you that captioning was brought to
you by Ford/Toyota/whomever) is often yellow.  However, I have never
seen myth draw a non-white 608 caption, even after this fix.  By
adding extra logging, it appears that the input to the min/max
truncation is always 0.  This is with HDHR OTA recordings.  I'm
wondering whether the color is being dropped by the HDHR, the myth
recorder, or the frontend player.  Have you observed a non-white 608
caption with the fixed code?

Jim