[mythtv] OSD timeout settings

[David Engel]

On Tue, Jun 15, 2010 at 01:13:35PM -0400, Michael T. Dean wrote:
> On 06/15/2010 11:21 AM, David Engel wrote:
> >On Tue, Jun 15, 2010 at 01:32:41PM +1000, Jean-Yves Avenard wrote:
> >>Following http://svn.mythtv.org/trac/changeset/25102
> >>
> >>Is the plan to have something equivalent with the new OSD theme, that
> >>is the user can easily change the timeout settings and how long one
> >>has to read text displayed on the screen.
> >>
> >>If it will require to fiddle with the theme XML to adjust how long you
> >>have to read things , that's a big drawback usability-wise IMO.
> >I agree completely.  I understand the desire, even need, for the
> >themes to control all visual aspects such as fonts so things look
> >right.  OSD timeouts don't affect the visual appearance of the themes
> >and should be easily configurable without having to edit XML.
> >
> 
> There is absolutely no code in MythTV that allows the OSD timeouts
> to change.  

And that's the rub.  The previous code might have had inconsistencies,
but it's a regression, IMHO, to remove all configurability and hard
code it.  Correct me if I'm wrong, but it looks like the current code
doesn't even allow changing the timeouts via the xml.

> This was true before I removed the widgets.  If someone
> wants the ability to change them, they need to write some code.

I will probably add a temporary hack to at least allow some basic
control of the OSD timeout.

> >FWIW, I'm also not thrilled with the change (unless I've misunderstood
> >it) that removes the ability to independently choose the OSD theme.  I
> >have no problem with a setting that defaults to using the OSD theme
> >provided by the main theme, but why not let the user choose a
> >different OSD theme if they want to?
> 
> I'm sure that could be changed, too--after all, why make a
> consistently-designed UI mandatory if the user wants things to look
> different in different places.  ;)  

Having the OSD theme resemble the main theme is not the most important
thing to me.  Things like having fonts that are readable with my poor
vision and fields in the locations I prefer are much, much, much more
important to me.  Consequently, I'd like to be free to independently
choose the main and OSD themes that best fit my needs.

> Again, someone just needs to
> write some code.  Mark had plenty of other stuff to do when he
> completely did the libmythui-osd changes all by himself, and, AIUI,
> allowing the user to independently change OSD theme was just one of
> those things that could be done later.

But the code for choosing independently was already there.  Maybe I'm
missing something.  What about the new mythui-osd implementation
requires that the osd theme come from the main theme?  If nothing, why
did this ability have to be removed.  Adding a few lines of new code
to support "use the main theme as OSD theme too" shouldn't be that
hard.

David
-- 
David Engel
david at istwok.net