[mythtv] Ticket #6346: Subtitle, Season #, and Episode # support for MythVideo
Robert McNamara
robert.mcnamara at gmail.com
Fri Apr 17 19:24:45 UTC 2009
On Fri, Apr 17, 2009 at 12:14 PM, MythTV <mythtv at cvs.mythtv.org> wrote:
> Comment(by Markus Schulz <msc at antzsystem.de>):
>
> nice work,
> perhaps you should add something like this to playercommand.cpp::PlayerFor
>
> QString title = item->GetTitle();
> if (item->GetSeason() > 0) {
> title += QString(" -
> %1x%2").arg(item->GetSeason()).arg(item->GetEpisode());
> }
> if (item->GetSubtitle().size()) {
> title += " " + item->GetSubtitle();
> }
>
> to get the full title in the OSD.
Hi Markus,
Thanks for the input-- You're right, the information *should* be
presentable in the OSD (and I would have no problem with Anduin adding
that tweak when he commits) but the reason I held off is because the
OSD will soon be converted to MythUI and that will allow the OSD
themer to put whatever information he wants wherever he wants (rather
than my needing to hack it in to the player command). I've limited my
changes here to "behind the scenes" and MythUI only. Like I said, if
that gets added when it gets committed, no problem with that.
Glad you're enjoying the patch, hope it's working well for you.
Robert
More information about the mythtv-dev
mailing list