[mythtv] bug recording uncompressed audio?

Isaac Richards ijr at case.edu
Fri Aug 19 02:14:09 UTC 2005


On Thursday 18 August 2005 09:26 pm, ame at spip.thehackers.org wrote:
> On Thu, 18 Aug 2005, Isaac Richards wrote:
> > Why bother even attaching a patch if it's completely untested?  For _me_
> > to test if it's fixed, I'll have to go find a bttv card, open up my dev
> > box, stick it in, configure it, etc, and test it.  Strangely enough,
> > that's exactly what I'd have to do if there wasn't a patch attached. 
> > Figure all that would take an hour or so.  The problem sounds relatively
> > simple, so debugging it from scratch would doubtfully add much time at
> > all, either. If the patch were tested, all I'd have to do would be to
> > look it over to make sure it didn't break anything else.  That'd take
> > about a minute, maybe 5 at the most.
>
> This is absolutely ridiculous. For god's sake, my patch only
> added one line of code!! Since you know your code, if you bothered
> trying to understand the bug I'm reporting, you'd realize this
> has nothing to do with capture cards or opening your dev box. mythtv
> is ignoring the configured setting and passing the wrong sampling
> rate to the ioctl on the audio device.

How exactly am I supposed to check to see if it's fixed if I don't have a 
capture card capable of analog recording?

> If I had sent my message including an explanation of where and
> why I thought the code was wrong, instead of a literal patch,
> perhaps I would have gotten a warmer reception.

Probably.  Why include a patch if you didn't intend it to be used?  What's 
helpful about that?

Isaac


More information about the mythtv-dev mailing list