[mythtv] Re: [mythtv-commits] mythtv commits

Daniel Kristjansson danielk at cat.nyu.edu
Thu Apr 14 03:13:55 UTC 2005


On Wed, 2005-04-13 at 22:51 -0400, Isaac Richards wrote:
> On Wednesday 13 April 2005 09:52 pm, Isaac Richards wrote:
> > On Wednesday 13 April 2005 08:50 pm, mythtv at cvs.mythtv.org wrote:
> > > -------------------------------------------------------------------------
> > >-- - Changes committed by danielk on Thu Apr 14 00:48:17 2005
> > >
> > > Modified Files:
> > >    in mythtv/libs/libmythtv:
> > >         tv_play.cpp
> > > Log Message:

> - Why the change in the destructor?
Suggested by Qt people as the code that would work in various
environments. Basically window decorations are added after show()
in X so for some window managers you need to call it then move(),
to get something in the right location.

> - You're always resizing/moving the mainWindow, even when it's not necessary.
> - a MythDialog is a child of the main window, so it can't have separate flags.
> - Why's myWindow being resized multiple times?
Cruft? It's hard to tell because I've added much of it to get this to
work on with other people's software stack.

The flags are just sleep deprivation, fluxbox wasn't getting rid of a 1
pixel black window border. I tried the flags because I forgot it was a
child window. I'll make a cleanup pass.

-- Daniel



More information about the mythtv-dev mailing list