[mythtv] Re: [mythtv-commits] mythtv commits

[Isaac Richards]

On Wednesday 13 April 2005 09:52 pm, Isaac Richards wrote:
> On Wednesday 13 April 2005 08:50 pm, mythtv at cvs.mythtv.org wrote:
> > -------------------------------------------------------------------------
> >-- - Changes committed by danielk on Thu Apr 14 00:48:17 2005
> >
> > Modified Files:
> >    in mythtv/libs/libmythtv:
> >         tv_play.cpp
> > Log Message:
> >
> > This adds some work-around code for the fluxbox window manager. You need
> > to uncomment an appropriately named define at the top of tv_play for the
> > hack to take effect.
>
> I don't think this is acceptable for a release, really.  The old code
> didn't have this problem, so things should either be fixed, or reverted.

Yeah, the code in tv_play doesn't make sense to me.
- You're always resizing/moving the mainWindow, even when it's not necessary.
- a MythDialog is a child of the main window, so it can't have separate flags.
- Why the change in the destructor?
- Why's myWindow being resized multiple times?

Isaac