[mythtv] Re: [mythtv-commits] mythtv commits

[Robert Tsai]

non-XRANDR builds are broken. My simple patch is below:

[rtsai at myth:~/src/packages/myth/mythtv/programs/mythfrontend]
(3:57pm) cvs diff -du
cvs diff: Diffing .
Index: globalsettings.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/programs/mythfrontend/globalsettings.cpp,v
retrieving revision 1.234
diff -d -u -r1.234 globalsettings.cpp
--- globalsettings.cpp  7 Apr 2005 15:33:50 -0000       1.234
+++ globalsettings.cpp  7 Apr 2005 19:57:38 -0000
@@ -2988,9 +2988,11 @@
     screen->addChild(RunInWindow());
     addChild(screen);
 
+#if defined(USING_XRANDR) || defined(CONFIG_DARWIN)
     const vector<DisplayResScreen> scr = GetVideoModes();
     if (scr.size())
         addChild(new VideoModeSettings());
+#endif /* USING_XRANDR || CONFIG_DARWIN */
 
     VerticalConfigurationGroup* dates = new VerticalConfigurationGroup(false);
     dates->setLabel(QObject::tr("Localization"));

On Thu, Apr 07, 2005 at 03:35:02PM +0000, mythtv at cvs.mythtv.org wrote:
> ----------------------------------------------------------------------------
> Changes committed by danielk on Thu Apr  7 15:33:49 2005
> 
> Added Files:
>    in mythtv/libs/libmyth:
>         DisplayResScreen.cpp DisplayResScreen.h util-x11.cpp 
>         util-x11.h 
> Modified Files:
>    in mythtv/libs/libmyth:
>         DisplayRes.cpp DisplayRes.h DisplayResOSX.cpp DisplayResOSX.h 
>         DisplayResX.cpp DisplayResX.h libmyth.pro mythcontext.cpp 
>         mythcontext.h settings.cpp settings.h 
>    in mythtv/libs/libmythtv:
>         tv_play.cpp tv_play.h videoout_quartz.cpp videoout_xv.cpp 
>         videoout_xvmc.cpp 
>    in mythtv/programs/mythfrontend:
>         globalsettings.cpp 
> Log Message:
> 
> This change looks bigger than it is. It changes the API on
> DisplayRes a little bit. It adds a GetVideoModes() call which lists
> all the valid resolutions and refresh rates. In addition, the switch
> resolution methods allow a refresh rate. The GetVideoModes() method
> allows us to use a combo box when specifying output resolutions,
> reducing user error.
> 
> Also, GetDisplayRes() returns the DisplayRes singleton even if the
> UseVideoModes setting is disabled. So the database needs to be
> queried seperately for that setting.
> 
> Also, the new GetAspectRatio() method returns the true aspect ratio,
> unless the user has a aspect overide set. The overide setting for
> this is now the desired aspect ratio, not "Alternate Aspect Ratio",
> allowing aspect ratios other than 4:3 and 16:9. Unfortunately any
> existing overides are ignored and must be re-configured.
> 
> The public class DisplayResScreen replaces the private dim_t class,
> adding refresh rate information.
> 
> util-x11.cpp contains GetNumberOfXineramaScreens() which returns the
> number of XineramaScreens, or 0 if Xinerama is not supported. This
> was in util.cpp, but Nigel suggested moving it because he is
> removing OS specific things from util.cpp. Nigel also deserves
> credit for getting DisplayResOSX working.
> 
> John Poet is still reporting a problem with resizing to HDTV sizes,
> but his problem exists in this patch and current CVS. The resizing
> to HDTV sizes in this patch works for me...

--Rob