[mythtv] [PATCH] small oss define patch (prelude to another ALSA patch)

David George david at thegeorges.us
Wed Oct 6 11:37:34 UTC 2004


On 10/6/2004 3:02 AM, Ed Wildgoose wrote:

> David George wrote:
>
>> Just a small patch to move the OSS define into libs/libmyth like the 
>> other audio services.  No sense in passing the -DUSING_OSS to 
>> everything when it is only needed in libmyth.  Also changes printf's 
>> in audiooutput.cpp to VERBOSE VB_IMPORTANT.
>>
>> This is a prelude to a large ALSA audio update which improves support 
>> for newer ALSA versions.  Currently MythTV works best with ALSA 
>> 1.0.5a.  Anything newer (and older) has not done well for me (and 
>> others).  I am currently testing with CVS ALSA.  As soon as I finish 
>> testing I will retest with 1.0.5a to make sure it still works also.
>>
>> The other major new feature of the upcoming ALSA patch is volume 
>> control support.
>
>
>
> Can I swap patches with you first!  I have made some big structural 
> changes to the Audio code to introduce a new concrete base class which 
> implements the basic algorithm that all the other concrete classes 
> inherit from.  This now means that the audio code is just a couple of 
> short functions to override instead of them all being copies of the 
> one big base module!

Sounds good...  Sounds really good.

>
> It's all tested with OSS, Alsa, and Jack outputs (I haven't done the 
> other libraries yet, but they should be easy to convert).
>
> Future plans were to also put in the event code from the Music player 
> library so that it can simply use the main audio libraries directly 
> instead of having it's own code.

That would be very nice!

>   Then to introduce volume changing code into each audio output 
> libray, so that the main volume change code can do volume control no 
> matter which output library is installed - sounds like you have this 
> bit covered already?

Basically what I did for volume control was created new OSS and ALSA 
classes like the method used in audiooutput.

>
> I will post a patch with the current work shortly

That would be great.  It sounds like we should start with your patch and 
see what parts of mine are even needed.

Thanks,
David



More information about the mythtv-dev mailing list