[mythtv] [PATCH] small oss define patch (prelude to another ALSA patch)

Ed Wildgoose lists at wildgooses.com
Thu Oct 7 06:59:17 UTC 2004


>
> Basically what I did for volume control was created new OSS and ALSA 
> classes like the method used in audiooutput.


I wonder whether it wouldn't make more sense to abstract the volume 
control idea.  Assume a range or 0-100, and then add a "ChangeVolume" 
function to each of the audio output classes.  The audiooutput code can 
be assumed to understand how to change volume for that driver for example?

Obviously there might still need to be some config for the relevant 
volume control, ie under OSS there can be multiple controls which affect 
volune apart from Master or DAC or whatever.  Suggest that this code 
moves into the reconfigure subroutine?

For some of the modules volume control will be no more advanced than 
changing the volume of the sound sent to the driver (ie multiply by a 
float number), this is true with Jack, but we are using 32bit floats by 
the time we do this, so audible degredation is minimal.

Code will come your way shortly

Ed W


More information about the mythtv-dev mailing list