[mythtv] PATCH Potential DataDirect icon solution

Anduin Withers awithers at anduin.com
Tue May 25 16:39:12 EDT 2004


> More realistically, I'd like to see a better name for the script,
> use default filenames and default args for something like:
> 
> $ mkiconmap
> $ mythfilldatabase -i -u

I don't care what the script name is, if you like mkiconmap I'll rename it
if I'm forced to send another patch, otherwise anyone committing it can
change the name.

As for the params, allowing short params like you list requires more work.
Param parsing in myth is done by hand with explicit dependencies on options
starting with --.

> I guess what I'm thinking is there is no point to having a default
> name used by mythfilldatabase unless we tell users to use it.

The default name is used by mythfilldatabase --export-icon-map as well, so
there is a point (though it is small one).

> As for "dni_", I see why you chose this. I think what would actually
> happen is that if the docs say to use "myicons.xml" most people will
> send in a "myicons.xml" file ;-).

True, that is why it is a few places.

So basically the list of things you want:
  - rename script
  - script uses same default filename
  - script grabs on run, by default
  - param names shorter

Everything except the param names is very little work and I'll happily do
(If I reworked the params it would be using getopt_long and I doubt that
would make everyone happy). Before that though I'd like to get some ruling
on my use of exception handling, I understand the resistance to allowing it
in but of course believe my use is legitimate. If it won't be accepted I can
rework that part as well.

-- 
Anduin Withers



More information about the mythtv-dev mailing list