[mythtv] Suggested change in oldrecord behaviour

[Ed Wildgoose]

How do people feel about a change in the way oldrecordings are 
handled.   I like the feature to stop me re-recording old stuff, but I 
find it a little aggressive in some cases.

First suggestion would be to disable it completely for single 
recordings.  The idea here is that if I deliberately set a single 
recording, then I probably knew what I was doing and it was deliberate.  
Simple patch to achieve this would be as follows:

In libs/libmythtv/scheduledrecording.cpp:

void ScheduledRecording::doneRecording(QSqlDatabase* db,
                                       const ProgramInfo& proginfo)
{
    if (getRecordingType() == kSingleRecord ||
        getRecordingType() == kFindOneRecord)
+    {
        remove(db);
+    } else {
        addHistory(db, proginfo);
+    }
}


The second area would be to look at adding a "watched" flag, and then if 
something is deleted or autoexpired before it is watched then we also 
remove it from the oldrecorded table.

Perhaps it would be easier though to simply remove the "addHistory" call 
from being called at the end of the recording and instead move it to 
when the recording is played?  It wouldn't neccessarily be as 
configurable as an option that only marks the show as recorded only when 
(say) you have watched for at least 30secs.

Are there already any convenient hooks to add this into?  Anyone believe 
that they would want the old behaviour rather than this (it's annoying 
to add yet another option...).  Anyone believe that this would cause any 
issues with the scheduler?

Thanks

Ed W