[mythtv] Suggested change in oldrecord behaviour

[Ed Wildgoose]

Ed Wildgoose wrote:

> How do people feel about a change in the way oldrecordings are 
> handled.   I like the feature to stop me re-recording old stuff, but I 
> find it a little aggressive in some cases.
>
> First suggestion would be to disable it completely for single 
> recordings.  The idea here is that if I deliberately set a single 
> recording, then I probably knew what I was doing and it was 
> deliberate.  Simple patch to achieve this would be as follows:


Actually, this patch looks better.  This way we still mark it as 
previously recorded, but only overwrite it if someone deliberately 
selects it again for a single recording option:

Index: programs/mythbackend/scheduler.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/programs/mythbackend/scheduler.cpp,v
retrieving revision 1.96
diff -u -r1.96 scheduler.cpp
--- programs/mythbackend/scheduler.cpp  13 Apr 2004 17:25:10 -0000      1.96
+++ programs/mythbackend/scheduler.cpp  3 May 2004 17:37:25 -0000
@@ -1186,6 +1186,7 @@
 " LEFT JOIN oldrecorded ON "
 "  ( "
 "    oldrecorded.title IS NOT NULL AND oldrecorded.title <> '' AND 
program.title = oldrecorded.title "
+"     AND record.type NOT IN (1,6)" //ignore old recorded for 
single_record and record_one
 "     AND "
 "    (((record.dupmethod & 0x02) = 0) OR (oldrecorded.subtitle IS NOT 
NULL AND oldrecorded.subtitle <> '' AND program.subtitle = 
oldrecorded.subtitle)) "
 "     AND "


> The second area would be to look at adding a "watched" flag, and then 
> if something is deleted or autoexpired before it is watched then we 
> also remove it from the oldrecorded table.
>
> Perhaps it would be easier though to simply remove the "addHistory" 
> call from being called at the end of the recording and instead move it 
> to when the recording is played?  It wouldn't neccessarily be as 
> configurable as an option that only marks the show as recorded only 
> when (say) you have watched for at least 30secs.


Just to be clear why this would be useful (for me).  I setup stuff like 
the Simpsons, and Friends and other stuff to record so that I have an 
episode or two kicking around for when I am bored.  However, they record 
far quicker than I can watch them, and then none of the episodes 
re-record when they re-run them a few weeks later, regardless of whether 
I watched them or not.  I would find it more useful if it actually 
*knew* which ones I had seen, and didn't re-record only those ones...

Looks like the best place to add in the "watched" flag is in 
"PlaybackBox::play"

Ed W