[mythtv] Update PVR 350 patch

IvanK. chepati at yahoo.com
Fri Jan 9 01:23:13 EST 2004


I had the same problem.  Had to manually remove two lines (what the patch 
does).  The two lines are:

if (editmode)
             nvp->SetPlaySpeed(1.0, false);

IvanK.

On Friday 09 January 2004 01:14 am, Carl wrote:
> Not sure if there is something else going on here, but when I apply this
> patch to a currently updated CVS tree, I get:
>
> # gzcat ~/Patches/2004-01-09/pvr350.patch.gz | patch -p0
> patching file libs/libmythtv/NuppelVideoPlayer.cpp
> patching file libs/libmythtv/NuppelVideoPlayer.h
> patching file libs/libmythtv/decoderbase.h
> patching file libs/libmythtv/ivtv-ext-api.h
> patching file libs/libmythtv/ivtvdecoder.cpp
> patching file libs/libmythtv/ivtvdecoder.h
> patching file libs/libmythtv/tv_play.cpp
> Hunk #8 FAILED at 1409.
> 1 out of 18 hunks FAILED -- saving rejects to file
> libs/libmythtv/tv_play.cpp.rej
> patching file libs/libmythtv/videoout_ivtv.cpp
> patching file libs/libmythtv/videoout_ivtv.h
> #
>
> The reject file looks like:
>
> # cat libs/libmythtv/tv_play.cpp.rej
> ***************
> *** 1408,1422 ****
>                       return;
>                   }
>                   editmode = nvp->EnableEdit();
> -                 if (editmode)
> -                     nvp->SetPlaySpeed(1.0, false);
>               }
>               else if (action == "TOGGLEBROWSE")
>                   DoProgramMenu();
>               else if (action == "CHANNELUP")
>                   DoSeek(-jumptime * 60, tr("Jump Back"));
>               else if (action == "CHANNELDOWN")
>                   DoSeek(jumptime * 60, tr("Jump Ahead"));
>               else
>                   handled = false;
>           }
> --- 1409,1421 ----
>                       return;
>                   }
>                   editmode = nvp->EnableEdit();
>               }
>               else if (action == "TOGGLEBROWSE")
>                   DoProgramMenu();
>               else if (action == "CHANNELUP")
>                   DoSeek(-jumptime * 60, tr("Jump Back"));
>               else if (action == "CHANNELDOWN")
>                   DoSeek(jumptime * 60, tr("Jump Ahead"));
>               else
>                   handled = false;
>           }
>
>
> This has been happening for awhile. It looks like an easy enough thing for
> patch to figure out, and manually making the change seems to work...
>
> Carl
>
> On Thursday January 8 2004 23:36, David Engel wrote:
> > Here is the latest, and hopefully last, version of my patch for
> > improved PVR 350 output.  It requires the latest ivtv driver as of
> > this morning.  As before, there is no new functionality -- only
> > changes to work with the new driver.
> >
> > Kevin has finished adding the required functionality to the ivtv
> > driver so no more driver patches are required and Myth no longer needs
> > to use the backdoor ioctl.  There is one minor driver issue Kevin is
> > still working on but it shouldn't cause serious problems in normal
> > use.
> >
> > If all goes well, Kevin will be making a formal driver release
> > tomorrow and my patch can go into Myth CVS sometime after that.  If
> > you've been using my patch, now is the time to speak up and give your
> > yay or nay if it's ready for CVS.
> >
> > David


More information about the mythtv-dev mailing list