[mythtv] MythMusic Patch Help

[m0j0.j0j0]

> 	However, you only seem to be dealing with playlists. AllMusic also puts 
> itself on the playing tree (up near the root node) and also calculates an 
> "intelligent" weight. So, for completeness, you should be doing something 
> similar in AllMusic->writeTree(). You shouldn't need an extra loop there as 
> there could easily be a global min/max setting that is figured out on the fly 
> during the initial metadata load.
> 

My goal was to deal with both. I had modified MusicNode::writeTree to
use the same math as Playlist::writeTree. I also created a few variables
in AllMusic (playcountMax, playcountMin, etc) to store the global
settings. I then passed these settings into MusicNode's using functions
like: setPlayCountMax. Not sure is this the right way to do this sort of
thing. I'd did this for the "traverse" nodes, but forgot to for the
"sub_traverse" nodes. The new patch corrects that. Both playlists and
allmusic *seem* to be working now.


> 	Can't hurt to test (I haven't it applied yet, just looked at it).


I've done some testing on a small music collection. I'll try and test it
better tonight or tomorrow night when I'm at home.

Thanks,
Joe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythmusic-ratings4.diff
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.snowman.net/pipermail/mythtv-dev/attachments/20030709/5fab8845/mythmusic-ratings4.bin