[mythtv] Is this it?

[Isaac Richards]

On Wednesday 18 September 2002 03:49 pm, Grant Taylor wrote:
> I think I might have found the bug whereby watching a
> recording-in-progress goes wonky when the recorder stops.  I'm not at
> home to actually test this out, but any correctness it might have
> should be obvious to the Isaacs among you...
>
> It appears that the frontend returns to the menu if the tv transitions
> to WatchingPreRecorded, as it does after the end of recording when you
> are still playing.  A better fix might be to define a
> WATCHING_SOMETHING() test macro (or inline, this not being C), since
> there are a lot of closely related states floating around.
>
> This represents one of at least two ways you can end up with the
> player still playing even though the frontend is drawing a menu on top
> of it.  The other is when you fast forward off the end.
>
> It's not obvious what WatchingOtherRecording is for.  Is this for the
> pip toggle?  Or is this for recording one thing while watching
> another?  In the second case it probably belongs in the while() test,
> too.

WatchingOtherRecording is for watching one thing while recording another, so, 
yea, it should belong in there, too.

Just committed it to CVS.  However, I'm pretty sure the new menu code won't 
show up on top of the video anymore because of a state change, since it 
doesn't continually get torn down and recreated after a selection anymore.  
But, better safe then sorry =)

Handling fast forwarding off the end is a little trickier, though..  I'll 
probably end up adding a flag saying 'in progress recording' to the player 
and not let it seek too close to the end..  But lemme think about it, first, 
there might be a cleaner way to handle that.

Isaac