[mythtv-commits] [MythTV/mythtv] eb5dfa: Remove useless error messages from frontend log

[Steve Erlenborn]

  Branch: refs/heads/fixes/35
  Home:   https://github.com/MythTV/mythtv
  Commit: eb5dfad4d3ea523c5477e23b79ea5d631dd42148
      https://github.com/MythTV/mythtv/commit/eb5dfad4d3ea523c5477e23b79ea5d631dd42148
  Author: Steve Erlenborn <1751095+SteveErl at users.noreply.github.com>
  Date:   2026-01-20 (Tue, 20 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/mythmediaoverlay.cpp

  Log Message:
  -----------
  Remove useless error messages from frontend log

In GetFrame(), reaching the end of a file being played
caused generation of an error message in the log. This
is normal behavior, not an error. The code has been
updated to check for a return code of AVERROR_EOF
(-541478725). When that appears, generation of an error
message will be avoided.

When MythOverlayWindow() is called by
MythMediaOverlay::GetWindow(), the Themed argument is
set to False. This causes Screen->Create() to return
False, even though there is no error. To avoid generation
of a misleading error message, the LOG message code has
been relocated to inside of MythOverlayWindow::Create().
In that routine, we'll only generate an error log message
if the call to LoadWindowFromXML() fails. If the Themed
argument is False, this log message won't be generated.

Resolves: #1252
(cherry picked from commit 0fc67b860c1eed30dfedaaacd9254cd6a99fffa0)



To unsubscribe from these emails, change your notification settings at https://github.com/MythTV/mythtv/settings/notifications