[mythtv-commits] [MythTV/mythtv] 5b96ac: Apple RAOP: Invert test to simplify code. (pt 1)

David Hampton noreply at github.com
Tue Jan 20 15:02:11 UTC 2026

Previous message (by thread): [mythtv-commits] [MythTV/mythtv] 839503: Bump frontend web interface to svelte 4
Next message (by thread): [mythtv-commits] [MythTV/mythtv] eb5dfa: Remove useless error messages from frontend log
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 5b96ac70770770923e0f0c65493ca06e5a1fa7c4
      https://github.com/MythTV/mythtv/commit/5b96ac70770770923e0f0c65493ca06e5a1fa7c4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp

  Log Message:
  -----------
  Apple RAOP: Invert test to simplify code. (pt 1)


  Commit: c04a1fe2d781f60e8f9a940b5fffee585a97b421
      https://github.com/MythTV/mythtv/commit/c04a1fe2d781f60e8f9a940b5fffee585a97b421
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp

  Log Message:
  -----------
  Apple RAOP: Reindent code. (pt 2)


  Commit: 3555ecd4251fd1946e4e4e9e12ddbdfa8b8c1463
      https://github.com/MythTV/mythtv/commit/3555ecd4251fd1946e4e4e9e12ddbdfa8b8c1463
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythplugins/mythgame/mythgame/gamehandler.cpp

  Log Message:
  -----------
  tidy: Fix mixing of const/non-const iterators in mythgame.

The Qt6 version of this code pairs a "constFind" with "end". This
needs to be a non-const lookup since the found item will be deleted,
making it the same as the Qt5 version.


  Commit: e0f9c6c989bef0b09b85e3d3f51e309c0606f3a4
      https://github.com/MythTV/mythtv/commit/e0f9c6c989bef0b09b85e3d3f51e309c0606f3a4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/mythudplistener.cpp

  Log Message:
  -----------
  tidy: Remove unused non-trivial variables.

One is removed entirely, the other is only used by Qt5 so goes behind
a conditional.


  Commit: fa8caf351f7b15dc2b036294e71a69e721e94b9e
      https://github.com/MythTV/mythtv/commit/fa8caf351f7b15dc2b036294e71a69e721e94b9e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/lcddevice.cpp
    M mythtv/libs/libmythbase/mythdownloadmanager.cpp

  Log Message:
  -----------
  Convert container java style iterators to STL iterators. (libmythbase)

Qt is phasing out java-style iterators.  When "strict" mode is
enabled, java iterators are disabled and only STL iterators may be
used.

https://doc.qt.io/qt-6/qtglobal.html#QT_ENABLE_STRICT_MODE_UP_TO


  Commit: 188c7a5437b6f527472a3ff38661b63092288081
      https://github.com/MythTV/mythtv/commit/188c7a5437b6f527472a3ff38661b63092288081
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythmetadata/imagemanager.cpp
    M mythtv/libs/libmythmetadata/metadatacommon.cpp

  Log Message:
  -----------
  Convert container java style iterators to STL iterators. (libmythmetadata)

Qt is phasing out java-style iterators.  When "strict" mode is
enabled, java iterators are disabled and only STL iterators may be
used.

https://doc.qt.io/qt-6/qtglobal.html#QT_ENABLE_STRICT_MODE_UP_TO


  Commit: 65c81f889d4b7c26a3d751d37d2c079dab84f898
      https://github.com/MythTV/mythtv/commit/65c81f889d4b7c26a3d751d37d2c079dab84f898
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
    M mythtv/libs/libmythtv/captions/teletextscreen.cpp
    M mythtv/libs/libmythtv/deletemap.cpp
    M mythtv/libs/libmythtv/io/mythmediabuffer.cpp
    M mythtv/libs/libmythtv/mheg/interactivescreen.cpp
    M mythtv/libs/libmythtv/tv_play.cpp

  Log Message:
  -----------
  Convert container java style iterators to STL iterators. (libmythtv)

Qt is phasing out java-style iterators.  When "strict" mode is
enabled, java iterators are disabled and only STL iterators may be
used.

https://doc.qt.io/qt-6/qtglobal.html#QT_ENABLE_STRICT_MODE_UP_TO


  Commit: 1fcb5df1205c9d70d37cde177dae4430c4f344e7
      https://github.com/MythTV/mythtv/commit/1fcb5df1205c9d70d37cde177dae4430c4f344e7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythuicomposite.cpp
    M mythtv/libs/libmythui/mythuieditbar.cpp
    M mythtv/libs/libmythui/mythuitext.cpp
    M mythtv/libs/libmythui/mythuithemecache.cpp
    M mythtv/libs/libmythui/mythuitype.cpp
    M mythtv/libs/libmythui/opengl/mythpainteropengl.cpp
    M mythtv/libs/libmythui/vulkan/mythpaintervulkan.cpp

  Log Message:
  -----------
  Convert container java style iterators to STL iterators. (libmythui)

Qt is phasing out java-style iterators.  When "strict" mode is
enabled, java iterators are disabled and only STL iterators may be
used.

https://doc.qt.io/qt-6/qtglobal.html#QT_ENABLE_STRICT_MODE_UP_TO


  Commit: fcfc340eb6cebcb22be833f3393c848b58778817
      https://github.com/MythTV/mythtv/commit/fcfc340eb6cebcb22be833f3393c848b58778817
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/programs/mythfrontend/upnpscanner.cpp
    M mythtv/programs/mythfrontend/videopopups.cpp

  Log Message:
  -----------
  Convert container java style iterators to STL iterators. (frontend)

Qt is phasing out java-style iterators.  When "strict" mode is
enabled, java iterators are disabled and only STL iterators may be
used.

https://doc.qt.io/qt-6/qtglobal.html#QT_ENABLE_STRICT_MODE_UP_TO


  Commit: 26cd430915c649539b0cd55c2f482bbc8aeba028
      https://github.com/MythTV/mythtv/commit/26cd430915c649539b0cd55c2f482bbc8aeba028
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h

  Log Message:
  -----------
  Move the OSD "pulse" code into its own function.

This allows some code simplification as conditional code nesting can
be converted in function returns.


  Commit: 3359a9bc2748f69e54c80bacb2e00bae206d5d98
      https://github.com/MythTV/mythtv/commit/3359a9bc2748f69e54c80bacb2e00bae206d5d98
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythtv/osd.cpp

  Log Message:
  -----------
  Convert container java style iterators to STL iterators. (osd)

Qt is phasing out java-style iterators.  When "strict" mode is
enabled, java iterators are disabled and only STL iterators may be
used.

https://doc.qt.io/qt-6/qtglobal.html#QT_ENABLE_STRICT_MODE_UP_TO


  Commit: 29aee1272a7a32d7546ca5e1b9742a110dfa8639
      https://github.com/MythTV/mythtv/commit/29aee1272a7a32d7546ca5e1b9742a110dfa8639
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythui/mythuilocation.cpp

  Log Message:
  -----------
  clazy: Fix warnings about container detach while holding a read lock.

Clazy is warning about two places in mythuilocation.cpp where code
holding a read lock is calling a function that can detach a container.
This can cause undefined behavior.

1) Use QStringList::join instead of manually building up a path name
   from its parts.

2) Replace a call to "last()", which apparently can detach, with
   "at(size()-1)" which never detaches.

https://github.com/KDE/clazy/blob/master/docs/checks/README-readlock-detaching.md


  Commit: c1cc67d06e0c82be23ff329a7e130ae9e25c4f41
      https://github.com/MythTV/mythtv/commit/c1cc67d06e0c82be23ff329a7e130ae9e25c4f41
  Author: David Hampton <mythtv at love2code.net>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.h

  Log Message:
  -----------
  Remove unused variable in zmliveplayer.


Compare: https://github.com/MythTV/mythtv/compare/839503c98715...c1cc67d06e0c

To unsubscribe from these emails, change your notification settings at https://github.com/MythTV/mythtv/settings/notifications

Previous message (by thread): [mythtv-commits] [MythTV/mythtv] 839503: Bump frontend web interface to svelte 4
Next message (by thread): [mythtv-commits] [MythTV/mythtv] eb5dfa: Remove useless error messages from frontend log
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the mythtv-commits mailing list