[mythtv-commits] [MythTV/mythtv] 179d41: Be consistent about the format of m_origRecPriorit...

Sun Mar 28 19:14:30 UTC 2021

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 179d4133bf5461787183296ec1cfec86931ee99b
      https://github.com/MythTV/mythtv/commit/179d4133bf5461787183296ec1cfec86931ee99b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/channelrecpriority.cpp

  Log Message:
  -----------
  Be consistent about the format of m_origRecPriorityData.

This map is used to prevent saving all channel priority values after
one is changed. Unfortunately it was storing the original priorities
in the map as a single character, and then comparing them to the
string version of the priorities.  I.E. Stored in the map as QChar(1)
and then compared to "1", which is QChar(33). This meant that all
priorities were updated every time.

Change this to consistently use the string version of the priority
when referencing this map. Myth should now only update changed
priorities.

  Commit: 16ccabb504d7a7ceeaa84919f9f62f8ead269f9a
      https://github.com/MythTV/mythtv/commit/16ccabb504d7a7ceeaa84919f9f62f8ead269f9a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/programs/mythbackend/httpstatus.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp

  Log Message:
  -----------
  qt6: Add a couple more explicit conversions from int->QString.

  Commit: 9ddc8f5889fdf4863693c8adf08ba5ecaf8a1a70
      https://github.com/MythTV/mythtv/commit/9ddc8f5889fdf4863693c8adf08ba5ecaf8a1a70
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.cpp
    M mythtv/programs/mythbackend/services/music.cpp
    M mythtv/programs/mythfilerecorder/mythfilerecorder.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp
    M mythtv/programs/mythutil/recordingutils.cpp

  Log Message:
  -----------
  qt6: Fix more places affected by ::size() changing int->size_t.

  Commit: b34dc428737bb63a2667dbbcf7f644afac34260d
      https://github.com/MythTV/mythtv/commit/b34dc428737bb63a2667dbbcf7f644afac34260d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/programs/mythtranscode/external/replex/mpg_common.cpp
    M mythtv/programs/mythtranscode/external/replex/ringbuffer.cpp
    M mythtv/programs/mythtv-setup/importicons.cpp

  Log Message:
  -----------
  qt6: Fix a couple more ambiguous conversion to QChar warnings.

  Commit: 746099acfd16f37220496ea50cf07f1c75c48986
      https://github.com/MythTV/mythtv/commit/746099acfd16f37220496ea50cf07f1c75c48986
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/setupwizard_audio.cpp

  Log Message:
  -----------
  qt6: Fix another "unable to deduce auto type" warning.

  Commit: 5cbebe11190f6751897168cd87d204c3b564ff68
      https://github.com/MythTV/mythtv/commit/5cbebe11190f6751897168cd87d204c3b564ff68
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/programs/mythfilldatabase/xmltvparser.cpp

  Log Message:
  -----------
  qt6: Fix ambiguous conversion warnings in xmltvparser.cpp.

  Commit: fbaa8c716adc5f844d20ff36a40ad104069bef49
      https://github.com/MythTV/mythtv/commit/fbaa8c716adc5f844d20ff36a40ad104069bef49
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythscreentype.cpp
    M mythtv/libs/libmythui/mythuitype.h

  Log Message:
  -----------
  qt6: Rework the widget focus code for QMultiMap changes.

In Qt6 is isn't possible to update iterators by adding "+ 1" or "-1"
to them. In all versions moving outside of the map produces undefined
results, so the current "begin() - 1" code is not guaranteed to work.

Clean up the NextPrevWidgetFocus code a little bit by finding the
currently focused widget and starting the loop there.  If looping to
find the next widget, only run the second pass until getting back to
the current widget, instead of running to the end.

  Commit: d3883285ca2c17bd1bc646d9d14b990e9813c8c1
      https://github.com/MythTV/mythtv/commit/d3883285ca2c17bd1bc646d9d14b990e9813c8c1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/mythvdpauhelper.h
    M mythtv/libs/libmythtv/opengl/mythvaapiglxinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvaapiinterop.h
    M mythtv/libs/libmythui/platforms/mythdisplayx11.h

  Log Message:
  -----------
  qt6: Prevent compilation failures from Qt6/X11 naming conflicts.

X11 has unqualified definitions for "None" and "Cursor" that cause
conflict warnings with the file qpointingdevice.h. Workaround these
problems by defining "Cursor" before including the X headers, so the X
headers use a different (but consistent) type name, and then
undefining both "None" and "Cursor" after the includes are done.

  Commit: df4da75b11d20adda274100729ccecfdbd8b50b5
      https://github.com/MythTV/mythtv/commit/df4da75b11d20adda274100729ccecfdbd8b50b5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h

  Log Message:
  -----------
  qt6: Fix warnings about copying QEvents in tv_play.

Construct new events in the heap and build a list of pointers, instead
of a list of objects. Remember to delete the events when the parent
object is deleted.

  Commit: 92f505679f9dc6c32903f5a7bd607f5dd188ef8a
      https://github.com/MythTV/mythtv/commit/92f505679f9dc6c32903f5a7bd607f5dd188ef8a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/HLS/HLSReader.cpp

  Log Message:
  -----------
  qt6: QMap::iterator no longer has an operator+ function in HLSReader.cpp.

Increment the iterator in a loop since bounds checking has already
been performed.

  Commit: 0f00673cc308d91c731bcd2753b8e7952e7b8a54
      https://github.com/MythTV/mythtv/commit/0f00673cc308d91c731bcd2753b8e7952e7b8a54
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythui/devices/mythinputdevicehandler.cpp

  Log Message:
  -----------
  qt6: Fix warnings about copying QEvents in mythinputdevicehandler.cpp.

  Commit: e674240fd63804cd5d8daa9e13bd8eed9a0c4a0c
      https://github.com/MythTV/mythtv/commit/e674240fd63804cd5d8daa9e13bd8eed9a0c4a0c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  qt6: Only try and configure Webkit and QtScript when compiling for Qt5.

  Commit: 44eff29920c4f109cf23797172788a856bcfc84e
      https://github.com/MythTV/mythtv/commit/44eff29920c4f109cf23797172788a856bcfc84e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/metaioflacvorbis.cpp
    M mythtv/libs/libmythmetadata/metaiooggvorbis.cpp

  Log Message:
  -----------
  Replace deprecated TagLib XiphComment::removeField function.

The function XiphComment::removeFields is the recommended replacement
and exists on Ubuntu 18.04, so go ahead and convert unconditionally.

  Commit: c76d430ad628c99470731ecdcead06b14e0202d4
      https://github.com/MythTV/mythtv/commit/c76d430ad628c99470731ecdcead06b14e0202d4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/metaioid3.cpp
    M mythtv/libs/libmythmetadata/metaioid3.h

  Log Message:
  -----------
  Replace deprecated TagLib String::null and String::isNull.

The empty String constructor and the function String::isEmpty are the
recommended replacements and exists on Ubuntu 18.04, so go ahead and
convert unconditionally.

  Commit: 27aa210294c4c8464a7ff5b5e37654fb1a06fd92
      https://github.com/MythTV/mythtv/commit/27aa210294c4c8464a7ff5b5e37654fb1a06fd92
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythsocket.cpp

  Log Message:
  -----------
  qt6: Fix parsing when reading from the command socket.

After converting the byte array to a string, qt5 ignored the NUL
character at the end when it was asked to trim white space from the
string. Qt6 does care about the NUL (and doesn't consider it white
space) so nothing is trimmed.  The QString::toInt function fails if it
sees any character other than a digit, thus it would always fail on
Qt6 where it had worked on Qt5.  Removing the padding byte at the end
of the array allows the same code to work on both version of Qt.

  Commit: 50f89ba43546b789179bb93be70ed24a397953e2
      https://github.com/MythTV/mythtv/commit/50f89ba43546b789179bb93be70ed24a397953e2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmyth/test/test_audioconvert/test_audioconvert.pro
    M mythtv/libs/libmyth/test/test_audioutils/test_audioutils.pro
    M mythtv/libs/libmyth/test/test_programinfo/test_programinfo.pro
    M mythtv/libs/libmyth/test/test_rssparse/test_rssparse.pro
    M mythtv/libs/libmyth/test/test_settings/test_settings.pro
    M mythtv/libs/libmythmetadata/test/test_lyrics/test_lyrics.pro
    M mythtv/libs/libmythmetadata/test/test_metadatagrabber/test_metadatagrabber.pro
    M mythtv/libs/libmythmetadata/test/test_musicmetadata/test_musicmetadata.pro
    M mythtv/libs/libmythmetadata/test/test_musicutils/test_musicutils.pro
    M mythtv/libs/libmythmetadata/test/test_videometadata/test_videometadata.pro
    M mythtv/libs/libmythtv/test/test_copyframes/test_copyframes.pro
    M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.pro
    M mythtv/libs/libmythtv/test/test_frequencies/test_frequencies.pro
    M mythtv/libs/libmythtv/test/test_iptvrecorder/test_iptvrecorder.pro
    M mythtv/libs/libmythtv/test/test_mpegtables/test_mpegtables.pro
    M mythtv/libs/libmythtv/test/test_mythiowrapper/test_mythiowrapper.pro
    M mythtv/libs/libmythtv/test/test_subtitlescreen/test_subtitlescreen.pro
    M mythtv/libs/libmythui/libmythui.pro
    M mythtv/programs/programs-libs.pro

  Log Message:
  -----------
  qt6: Explicitly include opengl in the list of qt modules.

In qt5 opengl was the primary graphics system and was included by
default. Qt6 is moving towards an abstraction called Rendering
Hardware Interface (RHI) that can handle OpenGL, Vulkan, Metal,
et. al., and therefore no longer includes opengl by default.

  Commit: a0eeba37726aa8d8494141ea3160fbd33d89a641
      https://github.com/MythTV/mythtv/commit/a0eeba37726aa8d8494141ea3160fbd33d89a641
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/videoscan.h

  Log Message:
  -----------
  Fix "comparison of integer expressions of different signedness" warning.

Use the same data type for all related lists.

  Commit: 935863469bbfc36963bd389b07e62883a2cae361
      https://github.com/MythTV/mythtv/commit/935863469bbfc36963bd389b07e62883a2cae361
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythdialogbox.cpp

  Log Message:
  -----------
  Fix warning when loading popup windows.

A popup window has no title area, so don't try and find the a
description for the title are in the theme.

  Commit: 8a8b4dc15224902336adf5efa7f15c53496c1c38
      https://github.com/MythTV/mythtv/commit/8a8b4dc15224902336adf5efa7f15c53496c1c38
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/test/test_mpegtables/test_mpegtables.cpp

  Log Message:
  -----------
  qt6: Remove space before timezone name.

Qt6 appears to have become pickier about the formatting of dates. It
now cares whether or not there is a space between the time and the
timezone, where Qt5 didn't. I.E. Qt5 allows "2013-07-16 12:33:37 Z",
but Qt6 requires "2013-07-16 12:33:37Z".

  Commit: 2185c54aa0e9f91cddab48fb5ad0a589244c0847
      https://github.com/MythTV/mythtv/commit/2185c54aa0e9f91cddab48fb5ad0a589244c0847
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/mytharchive.pro
    M mythplugins/mytharchive/mytharchivehelper/mytharchivehelper.pro
    M mythplugins/mythgame/mythgame/mythgame.pro

  Log Message:
  -----------
  qt6: A couple of plugins need to specify they use the 'widgets' module.

  Commit: 3d90e8cd543b0bee9a9a990d5cf2a62206e054cf
      https://github.com/MythTV/mythtv/commit/3d90e8cd543b0bee9a9a990d5cf2a62206e054cf
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythplugins/mythweather/mythweather/weatherSource.cpp

  Log Message:
  -----------
  qt6: Change from QTextCodec -> QStringConverter in mythweather.

  Commit: c37fc1051145f1a62d2719f66fc694be19026c5b
      https://github.com/MythTV/mythtv/commit/c37fc1051145f1a62d2719f66fc694be19026c5b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythplugins/configure
    M mythplugins/mythmusic/mythmusic/editmetadata.cpp
    M mythplugins/mythmusic/mythmusic/mythmusic.pro
    M mythplugins/mythmusic/mythmusic/streamview.h
    M mythplugins/mythmusic/mythmusic/visualizerview.cpp

  Log Message:
  -----------
  Remove unused remnants of mythbrowser from MythMusic.

  Commit: 34b412460b29d265cb8b925dde3192d5f026a8d9
      https://github.com/MythTV/mythtv/commit/34b412460b29d265cb8b925dde3192d5f026a8d9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp

  Log Message:
  -----------
  qt6: Fix "unable to deduce auto type" warnings in mythmusic.

  Commit: 73b836440d4ce09e5801fdf4fa78e420340e5e86
      https://github.com/MythTV/mythtv/commit/73b836440d4ce09e5801fdf4fa78e420340e5e86
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  Switch from taglib-config to pkg-config.

  Commit: d987abf9ae68cdfec79bd2dbcdea03706ff0d047
      https://github.com/MythTV/mythtv/commit/d987abf9ae68cdfec79bd2dbcdea03706ff0d047
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/eithelper.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp

  Log Message:
  -----------
  cppcheck: Reduce scope of variables.

  Commit: 788796b7e614d15788941405525517fe0f00c0f2
      https://github.com/MythTV/mythtv/commit/788796b7e614d15788941405525517fe0f00c0f2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/eithelper.h

  Log Message:
  -----------
  cppcheck: Mark a constructor as explicit.

  Commit: 13fda3984d4e9bac3687e9f53d62b8653b0a6040
      https://github.com/MythTV/mythtv/commit/13fda3984d4e9bac3687e9f53d62b8653b0a6040
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-03-27 (Sat, 27 Mar 2021)

  Changed paths:
    M mythtv/libs/libmythtv/livetvchain.cpp

  Log Message:
  -----------
  cppcheck: Fix a "value assigned is never used" warning.

Compare: https://github.com/MythTV/mythtv/compare/6d429d930ad0...13fda3984d4e