[mythtv-commits] [MythTV/mythtv] d3abb4: Convert ShowOkPopup to use new style Qt connect fu...

David Hampton noreply at github.com
Thu Oct 29 20:59:38 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: d3abb48a2604ab8afd267752aaa063da0a066b3e
      https://github.com/MythTV/mythtv/commit/d3abb48a2604ab8afd267752aaa063da0a066b3e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/editmetadata.cpp
    M mythplugins/mythmusic/mythmusic/generalsettings.cpp
    M mythplugins/mythmusic/mythmusic/generalsettings.h
    M mythplugins/mythmusic/mythmusic/importmusic.cpp
    M mythplugins/mythmusic/mythmusic/lyricsview.cpp
    M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp
    M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
    M mythplugins/mythmusic/mythmusic/streamview.cpp
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmyth/mythcontext.h
    M mythtv/libs/libmyth/standardsettings.cpp
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/videosource.h
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/libs/libmythui/mythdialogbox.h
    M mythtv/libs/libmythui/mythuicomposite.h
    M mythtv/programs/mythfrontend/prevreclist.cpp
    M mythtv/programs/mythfrontend/proglist.cpp

  Log Message:
  -----------
  Convert ShowOkPopup to use new style Qt connect function.

Using the newer "PMF" connect allows all of the function arguments to
be checked at compile time, instead of at run time.


  Commit: a969c7cfeb4f93b53fa27839e6043ccb46c3cfc1
      https://github.com/MythTV/mythtv/commit/a969c7cfeb4f93b53fa27839e6043ccb46c3cfc1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythsignalingtimer.cpp
    M mythtv/libs/libmythbase/mythsignalingtimer.h
    M mythtv/libs/libmythui/mythmainwindow.cpp

  Log Message:
  -----------
  Convert MythSignalingTimer constructor to use new style Qt connect function.

Using the newer "PMF" connect allows all of the function arguments to
be checked at compile time, instead of at run time.


  Commit: 5d74dfec2726e411a3e8edb5c33e5ee92c52547e
      https://github.com/MythTV/mythtv/commit/5d74dfec2726e411a3e8edb5c33e5ee92c52547e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythcorecontext.h
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp

  Log Message:
  -----------
  Convert WaitUntilSignals to use new style Qt connect function.

Using the newer "PMF" connect allows all of the function arguments to
be checked at compile time, instead of at run time.


  Commit: 1b873086f2fa993cd70cfdeebfb35e66a3018a53
      https://github.com/MythTV/mythtv/commit/1b873086f2fa993cd70cfdeebfb35e66a3018a53
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/videosource.h

  Log Message:
  -----------
  Convert videosource.cpp to use new style Qt connect function.

Using the newer "PMF" connect allows all of the function arguments to
be checked at compile time, instead of at run time.


  Commit: c0f9a0302d39db7f079069a0e4fb58e2ddf3e938
      https://github.com/MythTV/mythtv/commit/c0f9a0302d39db7f079069a0e4fb58e2ddf3e938
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/importnative.cpp
    M mythplugins/mytharchive/mytharchive/importnative.h

  Log Message:
  -----------
  Convert mytharchive/importnative.cpp to use new style Qt connect function.

Using the newer "PMF" connect allows all of the function arguments to
be checked at compile time, instead of at run time.


  Commit: 3ec7428c646eb2da665cc1f522cf062c115182ad
      https://github.com/MythTV/mythtv/commit/3ec7428c646eb2da665cc1f522cf062c115182ad
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythplugins/mythgame/mythgame/gamehandler.cpp
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/editmetadata.cpp
    M mythplugins/mythmusic/mythmusic/lyricsview.cpp
    M mythplugins/mythmusic/mythmusic/musiccommon.cpp
    M mythplugins/mythmusic/mythmusic/streamview.cpp
    M mythplugins/mythweather/mythweather/weatherSetup.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
    M mythtv/libs/libmyth/standardsettings.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/libs/libmythui/mythdialogbox.h
    M mythtv/libs/libmythui/myththemedmenu.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/schedulecommon.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythtv-setup/channeleditor.cpp

  Log Message:
  -----------
  Rename Mythdialog QVariant override functions to have unique names.

This prevents unexpected conversions to QVariant, that can cause
strange compiler warnings or strange program behavior. For example, a
argument that is a pointer to a function can be implicitly converted
to "QVariant(true)", and then the compiler complains that the address
of the function will never be NULL. Worse yet, this produces an
executable instead of failing, and the executable has missing
callbacks and doesn't function properly.


  Commit: f87c9e164f002808a68bd4c75cfbcf81572957f6
      https://github.com/MythTV/mythtv/commit/f87c9e164f002808a68bd4c75cfbcf81572957f6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/libs/libmythui/mythdialogbox.h
    M mythtv/libs/libmythui/mythuitype.h

  Log Message:
  -----------
  Change data type name From MythUIButtonCallback to MythUICallback.


  Commit: bf15fbee543eea9e08821d2b993d38b019b04714
      https://github.com/MythTV/mythtv/commit/bf15fbee543eea9e08821d2b993d38b019b04714
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/exportnative.cpp
    M mythplugins/mytharchive/mytharchive/logviewer.cpp
    M mythplugins/mytharchive/mytharchive/mythburn.cpp
    M mythplugins/mytharchive/mytharchive/recordingselector.cpp
    M mythplugins/mytharchive/mytharchive/thumbfinder.cpp
    M mythplugins/mytharchive/mytharchive/videoselector.cpp
    M mythplugins/mythbrowser/mythbrowser/bookmarkmanager.cpp
    M mythplugins/mythbrowser/mythbrowser/mythbrowser.cpp
    M mythplugins/mythbrowser/mythbrowser/mythbrowser.h
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/editmetadata.cpp
    M mythplugins/mythmusic/mythmusic/importmusic.cpp
    M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
    M mythplugins/mythmusic/mythmusic/visualizerview.cpp
    M mythplugins/mythnetvision/mythnetvision/netbase.cpp
    M mythplugins/mythnetvision/mythnetvision/netbase.h
    M mythplugins/mythnetvision/mythnetvision/netsearch.cpp
    M mythplugins/mythnetvision/mythnetvision/nettree.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmevents.cpp
    M mythtv/libs/libmyth/standardsettings.cpp
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/libs/libmythui/mythdialogbox.h
    M mythtv/libs/libmythui/mythuitype.h
    M mythtv/programs/mythfrontend/exitprompt.cpp
    M mythtv/programs/mythfrontend/exitprompt.h
    M mythtv/programs/mythfrontend/galleryslideview.cpp
    M mythtv/programs/mythfrontend/galleryslideview.h
    M mythtv/programs/mythfrontend/gallerythumbview.cpp
    M mythtv/programs/mythfrontend/gallerythumbview.h
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/playbackbox.h
    M mythtv/programs/mythfrontend/prevreclist.cpp
    M mythtv/programs/mythfrontend/proglist.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythfrontend/videodlg.h
    M mythtv/programs/mythtv-setup/exitprompt.cpp
    M mythtv/programs/mythtv-setup/startprompt.cpp
    M mythtv/programs/mythwelcome/welcomedialog.cpp

  Log Message:
  -----------
  Convert mythdialog to use new style Qt connect function.

Using the newer "PMF" connect allows all of the function arguments to
be checked at compile time, instead of at run time.

Add to 1e81b99a30 Convert mythdialog to use new style Qt connect function.


  Commit: 567b3e79be216c4c925945f7390e295adcab5cc5
      https://github.com/MythTV/mythtv/commit/567b3e79be216c4c925945f7390e295adcab5cc5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/musicplayer.cpp
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythcorecontext.h
    M mythtv/libs/libmythtv/AirPlay/mythraopdevice.cpp
    M mythtv/libs/libmythtv/tv_play.cpp

  Log Message:
  -----------
  Convert RegisterForPlayback to use new style Qt connect function.

Using the newer "PMF" connect allows all of the function arguments to
be checked at compile time, instead of at run time.


  Commit: e52800e48043e13c6178c4ce9853ab158f5977b4
      https://github.com/MythTV/mythtv/commit/e52800e48043e13c6178c4ce9853ab158f5977b4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythuibuttonlist.h
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythfrontend/statusbox.h

  Log Message:
  -----------
  Convert StatusBox to use new style Qt connect function.

Using the newer "PMF" connect allows all of the function arguments to
be checked at compile time, instead of at run time.


  Commit: edc2a3c54b759bd9a71c848b97f160c2ecef12f4
      https://github.com/MythTV/mythtv/commit/edc2a3c54b759bd9a71c848b97f160c2ecef12f4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp

  Log Message:
  -----------
  Fix unused parameter warning on android.


Compare: https://github.com/MythTV/mythtv/compare/01216865d16a...edc2a3c54b75


More information about the mythtv-commits mailing list