[mythtv-commits] [MythTV/mythtv] 18018e: MythPlayerCaptionsUI: Change inheritance order

Thu Oct 29 16:42:17 UTC 2020

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 18018e200fe9ecfed4ff2b58eb03e98a88327487
      https://github.com/MythTV/mythtv/commit/18018e200fe9ecfed4ff2b58eb03e98a88327487
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythtv/mythplayervideoui.h
    M mythtv/libs/libmythtv/mythplayervisualiserui.cpp
    M mythtv/libs/libmythtv/mythplayervisualiserui.h

  Log Message:
  -----------
  MythPlayerCaptionsUI: Change inheritance order

- move MythPlayerCaptionsUI before MythPlayerVideoUI in the inheritance
structure which avoids a few chicken/egg issues
- connect the ResizeForInteractiveTV signal directly to the
MythVideoOutput instance when it is created

  Commit: 42719fbfd12226463e9a1554584359e3d8d38f90
      https://github.com/MythTV/mythtv/commit/42719fbfd12226463e9a1554584359e3d8d38f90
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayerstate.cpp
    M mythtv/libs/libmythtv/mythplayerstate.h
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythtv/mythplayervideoui.h
    M mythtv/libs/libmythtv/mythvideobounds.cpp
    M mythtv/libs/libmythtv/mythvideobounds.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tvplaybackstate.h
    M mythtv/libs/libmythtv/videoouttypes.h

  Log Message:
  -----------
  MythPlayerVideoUI: Convert more methods to slots

  Commit: 1cafc2bc0e974e7796d961a7371ccf412f22a317
      https://github.com/MythTV/mythtv/commit/1cafc2bc0e974e7796d961a7371ccf412f22a317
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mheg/mhi.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/mythplayerstate.cpp
    M mythtv/libs/libmythtv/mythplayerstate.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  MythPlayerCaptionsUI: Cleanup threading for interactive TV support

- not complete as some methods need QObject support in the decoder -
which is not possible yet.

  Commit: dfdc3fef0f812105b1bff8133389a6352d1cf358
      https://github.com/MythTV/mythtv/commit/dfdc3fef0f812105b1bff8133389a6352d1cf358
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.h
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  MythPlayerCaptionsUI: Convert a raft of methods to signals/slots

  Commit: e8e72546e512eb8c36643f8965ffe20f3b2051bb
      https://github.com/MythTV/mythtv/commit/e8e72546e512eb8c36643f8965ffe20f3b2051bb
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/teletextreader.cpp
    M mythtv/libs/libmythtv/captions/teletextreader.h
    M mythtv/libs/libmythtv/captions/teletextscreen.cpp
    M mythtv/libs/libmythtv/captions/teletextscreen.h
    M mythtv/libs/libmythtv/mythcaptionsoverlay.cpp
    M mythtv/libs/libmythtv/mythcaptionsoverlay.h
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp

  Log Message:
  -----------
  MythCaptionsOverlay: Move teletext 'exit' handling into TeletextReader

  Commit: 28058cc90185655014e1170b66d7a3520ec34e35
      https://github.com/MythTV/mythtv/commit/28058cc90185655014e1170b66d7a3520ec34e35
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
    M mythtv/libs/libmythtv/mythcaptionsoverlay.cpp
    M mythtv/libs/libmythtv/mythcaptionsoverlay.h
    M mythtv/libs/libmythtv/mythmediaoverlay.cpp
    M mythtv/libs/libmythtv/mythmediaoverlay.h
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  OSD: Split out captions/interactive OSD

Refs #240 #263 #264

  Commit: e76975497f7b18bd0c541ae8476c39ce708d988c
      https://github.com/MythTV/mythtv/commit/e76975497f7b18bd0c541ae8476c39ce708d988c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayeroverlayui.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  TV: Convert a few more OSD updates to signals

  Commit: d8d13c53018b959afb501021f87c92350d7be876
      https://github.com/MythTV/mythtv/commit/d8d13c53018b959afb501021f87c92350d7be876
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  TV: Simplify some trivial signalling

- emit signals directly and connect to local lambdas to ensure local
state is updated as well

  Commit: 040b4dc755602ed2438c1d6785d98329497b27af
      https://github.com/MythTV/mythtv/commit/040b4dc755602ed2438c1d6785d98329497b27af
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tvplaybackstate.h
    M mythtv/programs/mythfrontend/guidegrid.cpp

  Log Message:
  -----------
  TV: Use ChangeMuteState signal directly

- and connect the GuideGrid::ToggleMute signal directly to the
TV::ChangeMuteState signal

  Commit: ed55081c8b9722555e193e6904f21c3622196a06
      https://github.com/MythTV/mythtv/commit/ed55081c8b9722555e193e6904f21c3622196a06
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdplayer.h
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/mythplayerui.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  MythPlayerUI: Use signal/slot for SetBookmark

  Commit: 93a166a14a7e970c5f12633d630dbb4903941eaf
      https://github.com/MythTV/mythtv/commit/93a166a14a7e970c5f12633d630dbb4903941eaf
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.h
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  MythPlayerCaptionsUI: Convert SetTrack to signal/slot

  Commit: c69a6f0c5455ce6ebe710637810d10e9728d599c
      https://github.com/MythTV/mythtv/commit/c69a6f0c5455ce6ebe710637810d10e9728d599c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/mythplayeroverlayui.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  MythPlayer: Convert SetAllowForcedSubtitles to signal/slot

  Commit: 36130e8f37e352c42a74680066ea697706b6d1de
      https://github.com/MythTV/mythtv/commit/36130e8f37e352c42a74680066ea697706b6d1de
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  MythPlayerCaptionsUI: Convert ChangeTrack to signal/slot

  Commit: 64a0db1865098fba5a6a0f3637c40a820ea05f7d
      https://github.com/MythTV/mythtv/commit/64a0db1865098fba5a6a0f3637c40a820ea05f7d
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayeroverlayui.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/mythplayervisualiserui.cpp
    M mythtv/libs/libmythtv/mythplayervisualiserui.h

  Log Message:
  -----------
  MythPlayer: Improve ReinitVideo handling in the UI classes

- move UI only triggers into the UI classes
- ensure AutoVisualise is only processed in the main thread

  Commit: b7136f049dba8220a3aad6a03eb22ad44754a480
      https://github.com/MythTV/mythtv/commit/b7136f049dba8220a3aad6a03eb22ad44754a480
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp

  Log Message:
  -----------
  MythPlayerCaptionsUI: Simplify ResetCaptions operation

- ensure it is thread safe when called from ClearAfterSeek (Note: This
will change soon so that it is only ever called from the main thread) -
but regardless, it needs to be signalled from the base class
- simplify ResetCaptions itself

  Commit: e2525726018f897d3411481ca24061486c4d7bae
      https://github.com/MythTV/mythtv/commit/e2525726018f897d3411481ca24061486c4d7bae
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideooutgpu.cpp

  Log Message:
  -----------
  MythVideoOutputGPU: Ensure we set m_buffersCreated

  Commit: 5d0a3683e5698e7fefbad2fd677bdfd36b83a4da
      https://github.com/MythTV/mythtv/commit/5d0a3683e5698e7fefbad2fd677bdfd36b83a4da
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayerstate.cpp
    M mythtv/libs/libmythtv/mythplayerstate.h

  Log Message:
  -----------
  MythPlayerState: Pass by value and use std::move

  Commit: 9a70209dd2d24bb8c5711abdad515a110fd8dd19
      https://github.com/MythTV/mythtv/commit/9a70209dd2d24bb8c5711abdad515a110fd8dd19
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideobounds.cpp

  Log Message:
  -----------
  MythVideoBounds: Fix cppcheck performance warning

hopefully

  Commit: 01216865d16a91ae43404c216f17fbb5fe2a2eb0
      https://github.com/MythTV/mythtv/commit/01216865d16a91ae43404c216f17fbb5fe2a2eb0
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  TV: Fix regression in clearing OSD

207da1777ad8cfac8b5e3513 removed the IsVisible method - which was in
fact the principle check to clear OSD screens that were visible (other
than dialogs etc). With that removed, the back/escape actions would just
exit playback.

Compare: https://github.com/MythTV/mythtv/compare/156f4db03031...01216865d16a