[mythtv-commits] Ticket #13571: Crash of backend on delete of program being recorded

[MythTV]

#13571: Crash of backend on delete of program being recorded
--------------------------------+-------------------------------
 Reporter:  Klaas de Waal       |          Owner:  Klaas de Waal
     Type:  Bug Report - Crash  |         Status:  closed
 Priority:  minor               |      Milestone:  32.0
Component:  MythTV - General    |        Version:  Master Head
 Severity:  medium              |     Resolution:  fixed
 Keywords:                      |  Ticket locked:  0
--------------------------------+-------------------------------
Changes (by Klaas de Waal <kdewaal@…>):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8e2872679315547abc3c2f1a91e0f7b8baac79dc/mythtv"
 8e28726793/mythtv]:
             {{{
             #!CommitTicketReference repository="mythtv"
 revision="8e2872679315547abc3c2f1a91e0f7b8baac79dc"
             Crash of backend on delete of program being recorded

 Fix this crash and similar backend crashes in the scheduler
 by replacing all iterations over m_tvList/m_encoderLink/m_pEncoders
 from using the Qt extension foreach to the C++11 range-based for loop.
 The foreach apparently makes a deep copy of the container thereby
 invalidating the iterators that may be active on the same container
 simultaneously in a different thread.
 As an additional safeguard the qAsConst, a Qt-specific variant
 of std:as_const, is added to all loops.

 Fixes #13571
             }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13571#comment:36>
MythTV <http://www.mythtv.org>
MythTV Media Center