[mythtv-commits] Ticket #13571: Crash of backend on delete of program being recorded

MythTV noreply at mythtv.org
Sat May 16 22:39:17 UTC 2020


#13571: Crash of backend on delete of program being recorded
--------------------------------+-------------------------------
 Reporter:  Klaas de Waal       |          Owner:  Klaas de Waal
     Type:  Bug Report - Crash  |         Status:  new
 Priority:  minor               |      Milestone:  32.0
Component:  MythTV - General    |        Version:  Master Head
 Severity:  medium              |     Resolution:
 Keywords:                      |  Ticket locked:  0
--------------------------------+-------------------------------

Comment (by David Hampton):

 Hi Klaus. The big difference that I see between the two patches is that
 your patch uses:

   for (auto var : qAsConst(blah))

 where mine uses:

   for (auto * var : qAsConst(blah))

 Using your patch the compiler will still correctly determine that the
 resulting auto variable should be a pointer, but explicitly stating that
 fact makes the code is easier to read.

 Other than that the two patches basically look identical.

 I am planning to revisit/replace all usage of the Q_FOREACH macro (and its
 alias foreach) in the core.

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13571#comment:35>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list