[mythtv-commits] Ticket #11587: Proposed patch for ClassicCommDetector.cpp for possible division by zero - fixes coverity 746805

[MythTV]

#11587: Proposed patch for ClassicCommDetector.cpp for possible division by zero -
fixes coverity 746805
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:  cpinkham
  <gary.buhrmaster@…>                            |     Status:  new
         Type:  Patch - Bug Fix                  |  Milestone:  unknown
     Priority:  minor                            |    Version:  Master Head
    Component:  MythTV - Mythcommflag            |   Keywords:
     Severity:  medium                           |
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 This (proposed) patch needs to be carefully looked at by someone with
 commercial detection expertise, and presumably access to a good set of
 sample  content so that any changes can be evaluated.

 There is a feasible (although I believe very unlikely) code path where no
 pixels will be checked, resulting in a number of variables not being
 appropriately set, which could result in a divide by zero (and a some
 other questionable calculations).  This code will bypass the code block if
 no pixels were checked.

 Fixes coverity 746805 (possible division by zero)

 Patch:
 https://github.com/garybuhrmaster/mythtv/commit/ef86c95b382eeb295c1eb1f291ad4bd088e731d9.patch

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/11587>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center