[mythtv-commits] Ticket #11587: Proposed patch for ClassicCommDetector.cpp for possible division by zero - fixes coverity 746805

[MythTV]

#11587: Proposed patch for ClassicCommDetector.cpp for possible division by zero -
fixes coverity 746805
-------------------------------------------------+-------------------------
 Reporter:  Gary Buhrmaster <gary.buhrmaster@…>  |          Owner:
     Type:  Patch - Bug Fix                      |  cpinkham
 Priority:  minor                                |         Status:  closed
Component:  MythTV - Mythcommflag                |      Milestone:  unknown
 Severity:  medium                               |        Version:  Master
 Keywords:                                       |  Head
                                                 |     Resolution:  fixed
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------
Changes (by Gary Buhrmaster <gary.buhrmaster@…>):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:c753154cebb04f29d974d6aa6a8f228275086211/mythtv]:
 {{{
 #!CommitTicketReference repository="mythtv"
 revision="c753154cebb04f29d974d6aa6a8f228275086211"
 [PATCH] Patch to bypass code when no pixels checked

 There is a feasible (although I believe very unlikely)
 code path where no pixels will be checked, resulting
 in a number of variables not being appropriately
 set.  This code will bypass the codes if no pixels
 were checked.

 Fixes coverity 746805 (possible division by zero)

 Fixes #11587.

 Signed-off-by: Chris Pinkham <cpinkham at mythtv.org>

 I have looked at the code and can see no negative effects if we
 skip the blank frame section and letter/pillar-box detection code
 in the unlikely event that we didn't check any pixels.  If we did
 not check any pixels, there are numerous variables within this
 section of code which are meaningless preventing valid detection.
 }}}

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/11587#comment:1>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center