[mythtv-commits] Ticket #4346: mythfilldatabase segfaulting periodically..

[MythTV]

#4346: mythfilldatabase segfaulting periodically..
------------------------------+---------------------------------------------
 Reporter:  damian at linux.ie   |        Owner:  nigel   
     Type:  defect            |       Status:  assigned
 Priority:  major             |    Milestone:  0.21    
Component:  mythfilldatabase  |      Version:  head    
 Severity:  high              |   Resolution:          
  Mlocked:  0                 |  
------------------------------+---------------------------------------------

Comment(by awithers):

 (In [15283]) References #4346

 upnptasknotify.cpp:
   * QStringList iteration isn't thread safe, add some locking around
     this. Also deep copy g_IPAddrList. The problem is that
     UPnpNotifyTask::Execute is call by the task queue and by the main
     thread (during SSDP shutdown).

 upnp.cpp:
   * UPnp::CleanUp was calling g_pSSDP->DisableNotifications() and then
     deleting g_pSSDP. SSDP::~SSDP() already calls DisableNotifications().

 What I didn't do:

 There doesn't seem to be a reason for UPnpNotifyTask::m_addressList to be
 a member, it should probably just be a deep copy in SendNotifyMsg to a
 local.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4346#comment:8>
MythTV <http://svn.mythtv.org/trac>
MythTV