[mythtv-commits] mythtv commit: r15283 by awithers

[mythtv at cvs.mythtv.org]

      Author: awithers
        Date: 2008-01-02 01:24:06 +0000 (Wed, 02 Jan 2008)
New Revision: 15283
   Changeset: http://cvs.mythtv.org/trac/changeset/15283

Modified:

   trunk/mythtv/libs/libmythupnp/upnp.cpp
   trunk/mythtv/libs/libmythupnp/upnptasknotify.cpp

Log:

References #4346

upnptasknotify.cpp:
  * QStringList iteration isn't thread safe, add some locking around
    this. Also deep copy g_IPAddrList. The problem is that
    UPnpNotifyTask::Execute is call by the task queue and by the main
    thread (during SSDP shutdown).

upnp.cpp:
  * UPnp::CleanUp was calling g_pSSDP->DisableNotifications() and then
    deleting g_pSSDP. SSDP::~SSDP() already calls DisableNotifications().

What I didn't do:

There doesn't seem to be a reason for UPnpNotifyTask::m_addressList to be
a member, it should probably just be a deep copy in SendNotifyMsg to a local.