[mythtv-users] Version 30.0 and toggle bookmarks confusion

[David Hampton]

On Tue, 2019-04-23 at 23:00 -0400, David Hampton wrote:
> On Tue, 2019-04-23 at 21:28 +0100, Paul Harrison wrote:
> > On 23/04/2019 20:53, Peter Bennett wrote:
> > 
> > > On 4/23/19 3:25 PM, Tom Dexter wrote:
> > > > I've read a few more threads on this and apparently you set
> > > > this
> > > > up
> > > > from the frontend under Setup -> Edit Keys under TV Playback,
> > > > which is
> > > > easy enough. If anything was added to do assign this
> > > > automatically I
> > > > sure can't find it in the code.
> > > The database schema update was supposed to automatically set up
> > > existing frontends to work they way they had previously. I
> > > suspect
> > > that may not be working correctly. You can set up the keys using
> > > "Edit
> > > keys" as you noted. The change is to allow you to customize the
> > > enter/return/space keys in TV playback instead of always having
> > > them
> > > set bookmarks.
> > > 
> > 
> > Those of us using master got the fix, at least I don't remember
> > having
> > to fix the keybindings manually, but the code to do the fixup was
> > removed before fixes/30 was released. Don't quite understand the
> > logic
> > behind that.
> > 
> > https://github.com/MythTV/mythtv/commit/453178430d86f7
> 
> Well, I was just doing what the comment at the top of the diffs for
> tv_play.cpp said to do.  It said to delete that code block when
> consolidating database version 1348, so I did.  I'll revert it since
> I committed it, and then let the original author figure out when/how
> to eventually remove it.
> 
> David

Code restored to master and fixes/30 branches.

David