[mythtv-users] Cutlist editor and bookmarks in master

[Jim Stichnoth]

On Wed, Aug 5, 2015 at 8:39 AM, George Nassas <gnassas at mac.com> wrote:

> On Aug 4, 2015, at 9:03 AM, Jim Stichnoth <stichnot at gmail.com> wrote:
>
>
> Mythtranscode should be removing those marks:
>
> https://github.com/MythTV/mythtv/blob/master/mythtv/programs/mythtranscode/main.cpp#L1065
> It leaves only the bookmark, and updates the bookmark to reflect the
> cutlist.
>
>
> Wondering about this update part - I don’t see where the bookmark gets
> updated to reflect the cut list. Is it right in front of me and just I
> don’t see it?
>

See ComputeNewBookmark().  Which btw should be removed, and the caller
should call DecoderBase::TranslatePositionAbsToRel() instead.


>
> Taking this is a slightly different direction, my general experience is
> bookmarks don’t get adjusted after a lossless transcode so you end up with
> a stray mark pointing mid-scene or past the end of the recording. It used
> to be, maybe years ago, that bookmarks would be removed after a lossless
> transcode but somewhere along the line that stopped happening.
>

Ticket #7731 changed the behavior from "delete bookmark" to "translate
bookmark".  This applies only to mythtranscode, and not to any third-party
scripts that do lossless transcode.  To debug problems like this, it would
be helpful to have the before-and-after output of "mythutil --getmarkup",
though I realize that once you discover a problem, it's usually too late to
get the pre-transcode data.  Which brings me on a tangent.  If I were still
using mythtranscode these days (as opposed to just using cutlists and
throwing marginally more disk space at the problem), I would try to change
things so that (1) the original file is deleted in the same way regular
recordings are deleted, i.e. keep around for N days before permanently
deleting; (2) there is a UI for restoring an old version.  This is probably
best done by cloning the original recording and its metadata, and using the
existing delete-recording mechanism on the original.

Jim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-users/attachments/20150805/50b79161/attachment.html>