[mythtv] Removing libmythbluray and libudfread

[Scott Theisen]

On 6/15/24 15:08, John P Poet wrote:
> On Sat, Jun 15, 2024 at 11:40 AM Scott Theisen 
> <scott.the.elm at gmail.com> wrote:
>
>     Hello all,
>
>     Is there any reason to keep libmythbluray?  Our internal version
>     is 1.2.1 and mythtv will use the system version if >=0.9.3.  As
>     far as I can tell, all of our targets have a packaged version (
>     https://pkgs.org/search/?q=libbluray ) of the current 1.3.4
>     release.  EL8 was previously mentioned as not having an official
>     package, but EL9 does.
>
>     Regarding libudfread (internal version 1.1.1, current version
>     1.1.2, mythtv uses system version if >=1.1.1), the list is shorter
>     ( https://pkgs.org/search/?q=libudfread ), but *does* include all
>     of our targets.  How would removing it effect building/packaging
>     on other platforms?
>
>     Regards,
>
>     Scott
>
>
> Personally, I would like to see libbluray become optional. What is it 
> used for beyond playing physical media? How many people use MythTV to 
> play physical media?
>
> John

libudfread is only used by libmythbase/mythcdrom.cpp to determine if a 
disk image is a DVD or a Blu-ray.

libbluray is used by:
mythtv/libs/libmythmetadata/bluraymetadata.cpp
mythtv/libs/libmythmetadata/bluraymetadata.h
mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp
mythtv/libs/libmythtv/Bluray/mythbdinfo.cpp
mythtv/libs/libmythtv/Bluray/mythbdinfo.h
mythtv/libs/libmythtv/Bluray/mythbdiowrapper.cpp
mythtv/libs/libmythtv/Bluray/mythbdoverlay.h

I didn't look that closely, but it seems to be only for reading Blu-ray 
disks (which makes sense).  It is also likely used to play a Blu-ray 
disk image.  If you want to make it optional, perhaps you could use 
FFmpeg's libbluray support instead of using it directly?

Scott
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20240615/658673c3/attachment.htm>