[mythtv] macOS build issues - looking for advice / pointers

[John Hoyt]

On Sat, Mar 4, 2023 at 4:52 AM Nigel Pearson <nigel.pearson.au at gmail.com>
wrote:

> Sorry for the delay.
>
> Haven't built anything on MacOS for years,
> but I would create a new constant,
> MAC_IO_SERVICE_DEPRECATED,
> which is set on OS > 11.7.
>
> If defined,
> the .cpp files create the old kBlahPropertyElementblah constants?
>
>
>
> On 17 Feb 2023, at 12:37 pm, John Hoyt <john.hoyt at gmail.com> wrote:
>
> On Mon, Feb 13, 2023 at 3:32 AM Nigel Pearson <nigel.pearson.au at gmail.com>
> wrote:
>
>>
>> It was ugly code when I wrote it (in 2008!!!).
>>
>> I think AppleRemote::  has outlived its usefulness.
>>
>>
>> git rm ???
>>
>
> So it looks like more functions were affected than just the AppleRemote
> logic.  Replacing all of the OS 12 defines in commit 3787583
> <https://github.com/MythTV/mythtv/commit/37875831a06acb651bfb545b3482281a0bb90caa>
>
> <https://github.com/MythTV/mythtv/commit/37875831a06acb651bfb545b3482281a0bb90caa>as
> follows got it sorted on Big Sur.
>
> -#if !defined(MAC_OS_VERSION_12_0)
> +#if !defined(MAC_OS_VERSION_12_0) || !defined(MAC_OS_VERSION_11_7)
>
> Any suggestion on a cleaner approach?
>
>
Thanks Nigel!

After looking into the deprecated macros, it turned out they were all being
set to 0 or NULL..  As such, David Hampton suggested creating a new static
constant which was committed here:
https://github.com/MythTV/mythtv/commit/c273ed0f9a2491b7f6ec377be0a0a861f7788849

Neither of us were all too keen to create a new MAC_OS specific variable.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20230304/369b4288/attachment.htm>