[mythtv] [mythtv-commits] [MythTV/mythtv] 035a52: No discontinuity for first TS packet of PID

[Klaas de Waal]

On Sat, 29 Aug 2020 at 23:05, kmdewaal <noreply at github.com> wrote:

>   Branch: refs/heads/master
>   Home:   https://github.com/MythTV/mythtv
>   Commit: 035a528bd813d5ca86999618875bba72162d8429
>
> https://github.com/MythTV/mythtv/commit/035a528bd813d5ca86999618875bba72162d8429
>   Author: David Engel <david at istwok.net>
>   Date:   2020-08-29 (Sat, 29 Aug 2020)
>
>   Changed paths:
>     M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
>     M mythtv/libs/libmythtv/recorders/dtvrecorder.h
>
>   Log Message:
>   -----------
>   No discontinuity for first TS packet of PID
>
> Improved version of commit cf8015eaf4a2fde6ece423e7ade99c86f7f9d076
> The previous version did remove all false positives but it
> suppressed 1/16th of the first real discontinuities.
>
>
> I do feel a bit silly. It looks like the only thing that needs to be done
to fix the code is to initialize all elements of m_continuityCounter to
0xff. The function CheckCC in dtvrecorder.h does already test for value
0xff. In mythv version 30  a memset is used to set all elements of
continuity_counter (as it was called then) to 0xff.
Somewhere along the way the initialization must have been lost. To be
continued.

Klaas.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mythtv.org/pipermail/mythtv-dev/attachments/20200829/d3149347/attachment.htm>