[mythtv] EIT fix for Norwegian DVB-T -- feed back and testing please ?
Håkon Alstadheim
hakon at alstadheim.priv.no
Fri May 21 12:23:44 UTC 2010
Hi all, I have a patch for doctoring eit info on norwegian dvb-t, see
attachment. Where is the correct place to send it? The patch is against
0.23-fixes rev 24755. See attached file. I'm pretty happy with the
effect of this patch, but I'm sure somebody will have advice on
coding-style. I've mentioned this patch on the list (and the users list
I believe), but I've had no testers step forward. If the code is
unacceptable as is, at least I'd like to reserve an enum number in
FixUpType in eitfixup.h. I'm pretty sure my code will have no adverse
effects on functionality. There should be no visible difference to
anyone outside Norway.
Coding style:
I'm not a professional programmer (pretty sure it shows), but I've tried
to factor the code in a reasonable way. I've found no obvious
commonalities though, so maybe I'd be better off with just one long
function ?
Iffiness:
I've noticed some very few entries in the database for programid and
seriesid that are clearly garbage. These prevent the frontend from
displaying the recorded programs and the schedule. Setting them to the
empty string in the database restored functionality. Don't know If I
should use the fix up function to just set to empty all
programid/seriesid that contain non-ASCII characters. I'm pretty sure
the garbage is not a result of my code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: myth-NRK-eit-fix.diff
Type: text/x-patch
Size: 11054 bytes
Desc: not available
URL: <http://mythtv.org/pipermail/mythtv-dev/attachments/20100521/641f99da/attachment.bin>
More information about the mythtv-dev
mailing list