[mythtv] DVD playback AV sync issues: all solved (?)

Taylor Ralph taylor.ralph at gmail.com
Fri Feb 5 05:52:50 UTC 2010

On Thu, Feb 4, 2010 at 10:30 PM, Davin McCall <davmac at davmac.org> wrote:
> On 05/02/10 06:04, Daniel Kristjansson wrote:
>> On Tue, 2010-02-02 at 18:39 +1100, Davin McCall wrote:
>>> The patch has been reverted now, anyway; I may re-do it with KeepPhase
>>> and the frame allowance left in. But please, discuss. I would have liked
>>> to get more feedback/questions *before* the dang patch was applied.
>> Davin, can you produce a set patches with each of the different parts
>> separated out so they can be tested separately?
> I've separated out the main part, i.e. removed the changes that Taylor
> questioned, now available as:
> (To view)
> http://svn.mythtv.org/trac/attachment/ticket/7067/mythtv.3.patch
> (To download)
> http://svn.mythtv.org/trac/raw-attachment/ticket/7067/mythtv.3.patch
> I'm having trouble testing it, since my box won't play anything since r23304
> (which I'll look into when I get time), but it compiles fine; I won't ask
> anyone else to test it unless they really want to :)
> As for the other changes, I'll worry about them once I can actually use myth
> again.
> Davin

I just found one issue so far. You've got the m_can_double comparison
backwards which causes 2x deinterlacing to be disabled.

Other than that it looks good. It definitely simplifies the code and
gets rid of all the SetFrameInterval calls scattered everywhere. I've
got it applied to my trunk system and also adapted it to my
0.22-fixes. So far so good. I'll give it a few days to soak and report

Thanks for the quick turn around!



More information about the mythtv-dev mailing list